annotations: Simplify negative logic

c3d · fidencio · commit f4dd7298b233 · 2020-11-11T09:34:41.000+01:00
Replace strange negative logic (!ok -> continue) with positive logic (ok -> do it) Fixes: #3004 Signed-off-by: Christophe de Dinechin <dinechin@redhat.com>
diff --git a/virtcontainers/pkg/oci/utils.go b/virtcontainers/pkg/oci/utils.go
@@ -375,11 +375,9 @@ func addAssetAnnotations(ocispec specs.Spec, config *vc.SandboxConfig) error {
 
 	for _, a := range assetAnnotations {
 		value, ok := ocispec.Annotations[a]
-		if !ok {
-			continue
+		if ok {
+			config.Annotations[a] = value
 		}
-
-		config.Annotations[a] = value
 	}
 
 	return nil

Original file line number	Diff line number	Diff line change
`@@ -375,11 +375,9 @@ func addAssetAnnotations(ocispec specs.Spec, config *vc.SandboxConfig) error {`
`375`	`375`
`376`	`376`	`for _, a := range assetAnnotations {`
`377`	`377`	`value, ok := ocispec.Annotations[a]`
`378`		`- if !ok {`
`379`		`- continue`
	`378`	`+ if ok {`
	`379`	`+ config.Annotations[a] = value`
`380`	`380`	`}`
`381`		`-`
`382`		`- config.Annotations[a] = value`
`383`	`381`	`}`
`384`	`382`
`385`	`383`	`return nil`