annotations: Simplify negative logic

c3d · fidencio · commit 3d8ce2ccc60e · 2020-11-11T09:39:34.000+01:00
Replace strange negative logic (!ok -> continue) with positive logic (ok -> do it) Fixes: #3004 Signed-off-by: Christophe de Dinechin <dinechin@redhat.com>
diff --git a/virtcontainers/pkg/oci/utils.go b/virtcontainers/pkg/oci/utils.go
@@ -372,11 +372,9 @@ func addAssetAnnotations(ocispec specs.Spec, config *vc.SandboxConfig) error {
 
 	for _, a := range assetAnnotations {
 		value, ok := ocispec.Annotations[a]
-		if !ok {
-			continue
+		if ok {
+			config.Annotations[a] = value
 		}
-
-		config.Annotations[a] = value
 	}
 
 	return nil

Original file line number	Diff line number	Diff line change
`@@ -372,11 +372,9 @@ func addAssetAnnotations(ocispec specs.Spec, config *vc.SandboxConfig) error {`
`372`	`372`
`373`	`373`	`for _, a := range assetAnnotations {`
`374`	`374`	`value, ok := ocispec.Annotations[a]`
`375`		`- if !ok {`
`376`		`- continue`
	`375`	`+ if ok {`
	`376`	`+ config.Annotations[a] = value`
`377`	`377`	`}`
`378`		`-`
`379`		`- config.Annotations[a] = value`
`380`	`378`	`}`
`381`	`379`
`382`	`380`	`return nil`