This repository was archived by the owner on May 12, 2021. It is now read-only.
tmp: Do not remove tmp.mount unit file from the rootfs#301
Merged
devimc merged 1 commit intokata-containers:masterfrom May 31, 2019
Merged
tmp: Do not remove tmp.mount unit file from the rootfs#301devimc merged 1 commit intokata-containers:masterfrom
devimc merged 1 commit intokata-containers:masterfrom
Conversation
We should start this unit so that systemd can mount /tmp as tmpfs. Fixes kata-containers#300 Signed-off-by: Archana Shinde <[email protected]>
amshinde
added a commit
to amshinde/agent-1
that referenced
this pull request
May 30, 2019
Invoke tmp.mount by adding it to kata-containers.target. This is not invoked by systemd with current rootfs setup we have as one of the dependencies for tmp.mount is systemd-remount-fs.service which depends on /etc/fstab file being present(it is currenty missing) Instead of adding that file, start the tmp.mount unit by including it in kata-containers.target With this and change in os-builder to not delete the tmp.mount unit, (kata-containers/osbuilder#301) /tmp should now be writeable for systemd based images. For initrd this is handled by the agent itself. Fixes #kata-containers/osbuilder#300 Signed-off-by: Archana Shinde <[email protected]>
jodh-intel
approved these changes
May 31, 2019
jodh-intel
left a comment
jodh-intel
left a comment
There was a problem hiding this comment.
lgtm.
Note: This needs to land before kata-containers/agent#564.
|
/test |
grahamwhaley
approved these changes
May 31, 2019
Contributor
|
FC CI looks unhappy: |
devimc
approved these changes
May 31, 2019
Member
Author
|
@grahamwhaley Just taking a look, did the FC CI just get fixed? |
|
@amshinde yup |
Member
Author
|
@grahamwhaley @GabyCT @devimc We do need to have a test for this. Yes this is going to be tricky. |
amshinde
added a commit
to amshinde/agent-1
that referenced
this pull request
May 31, 2019
Invoke tmp.mount by adding it to kata-containers.target. This is not invoked by systemd with current rootfs setup we have as one of the dependencies for tmp.mount is systemd-remount-fs.service which depends on /etc/fstab file being present(it is currenty missing) Instead of adding that file, start the tmp.mount unit by including it in kata-containers.target With this and change in os-builder to not delete the tmp.mount unit, (kata-containers/osbuilder#301) /tmp should now be writeable for systemd based images. For initrd this is handled by the agent itself. Fixes kata-containers#565 Signed-off-by: Archana Shinde <[email protected]>
Contributor
|
Seems like this change broke the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should start this unit so that systemd can mount /tmp as
tmpfs.
Fixes #300
Signed-off-by: Archana Shinde [email protected]