tmp: Add tmp.mount to kata-containers.target#564
tmp: Add tmp.mount to kata-containers.target#564jodh-intel merged 1 commit intokata-containers:masterfrom
Conversation
| [Unit] | ||
| Description=Kata Containers Agent Target | ||
| Requires=basic.target | ||
| Requires=tmp.mount |
There was a problem hiding this comment.
There was a problem hiding this comment.
Ah - and now I find that we did, but we're re-adding it on kata-containers/osbuilder#301 :)
jodh-intel
left a comment
jodh-intel
left a comment
There was a problem hiding this comment.
lgtm.
But we need to block on kata-containers/osbuilder#301 so I'll add a dnm label for now...
|
I think the CI fixes check is not happy parsing your fixes line. I think we've seen this before eh @jodh-intel - @amshinde , you probably have to have an Issue in this repo to link to. |
|
Yep - please just specify |
Invoke tmp.mount by adding it to kata-containers.target. This is not invoked by systemd with current rootfs setup we have as one of the dependencies for tmp.mount is systemd-remount-fs.service which depends on /etc/fstab file being present(it is currenty missing) Instead of adding that file, start the tmp.mount unit by including it in kata-containers.target With this and change in os-builder to not delete the tmp.mount unit, (kata-containers/osbuilder#301) /tmp should now be writeable for systemd based images. For initrd this is handled by the agent itself. Fixes kata-containers#565 Signed-off-by: Archana Shinde <[email protected]>
amshinde
force-pushed
the
start-tmp-mount-unit
branch
from
e445336 to
06a0743
Compare
|
/test |
Codecov Report
@@ Coverage Diff @@
## master #564 +/- ##
=======================================
Coverage 50.48% 50.48%
=======================================
Files 17 17
Lines 2385 2385
=======================================
Hits 1204 1204
Misses 1025 1025
Partials 156 156 |
|
18.04 CI is failing with: |
|
/test |
|
@GabyCT I know the fedora tests were failing the other day. Are the vsocks tests supposed to pass ? |
|
@amshinde the reason why |
|
@jodh-intel @kata-containers/agent PTAL. I think this can be merged. |
|
Agreed... |
4 participants
Invoke tmp.mount by adding it to kata-containers.target.
This is not invoked by systemd with current rootfs setup we have
as one of the dependencies for tmp.mount is systemd-remount-fs.service
which depends on /etc/fstab file being present(it is currenty missing)
Instead of adding that file, start the tmp.mount unit by including
it in kata-containers.target
With this and change in os-builder to not delete the tmp.mount unit,
(kata-containers/osbuilder#301) /tmp should now
be writeable for systemd based images.
For initrd this is handled by the agent itself.
Fixes #kata-containers/osbuilder#300
Signed-off-by: Archana Shinde [email protected]