Skip to content

Commit b5512b0

Browse files
committed
docs(integrations): say why SHAI argv routes can't run Spec Kit commands
SHAI does take headless prompt text as positional arguments, on stdin and through `shai agent <name> <prompt>`, so "no argv form that runs a prompt" was wrong. Every route goes to its auto-fix agent and .shai/commands is never loaded, which is why dispatch stays disabled. Reword the code comment, the test docstring and the integrations reference to say that. Refs github#2416 Assisted-by: Claude Code (model: claude-opus-5-5, autonomous)
1 parent c4ec01c commit b5512b0

3 files changed

Lines changed: 16 additions & 13 deletions

File tree

‎docs/reference/integrations.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ The Specify CLI supports a wide range of AI coding agents. When you run `specify
4242
| [Qoder CLI](https://qoder.com/cli) | `qodercli` | |
4343
| [Qwen Code](https://github.com/QwenLM/qwen-code) | `qwen` | |
4444
| [RovoDev](https://www.atlassian.com/software/rovo-dev) | `rovodev` | Generates `.rovodev/skills/`, prompt wrappers, and `prompts.yml`; runtime dispatch uses `acli rovodev` |
45-
| [SHAI (OVHcloud)](https://github.com/ovh/shai) | `shai` | Workflow `command` and `prompt` steps can't run through SHAI: its CLI has no argument form that runs a prompt, so those steps fail |
45+
| [SHAI (OVHcloud)](https://github.com/ovh/shai) | `shai` | Workflow `command` and `prompt` steps can't run through SHAI: its CLI accepts prompt text (as arguments, on stdin, or through `shai agent`), but hands it to its auto-fix agent and never loads `.shai/commands`, so those steps fail |
4646
| [Tabnine CLI](https://docs.tabnine.com/main/getting-started/tabnine-cli) | `tabnine` | |
4747
| [Trae](https://www.trae.ai/) | `trae` | Skills-based integration; skills are installed automatically |
4848
| [ZCode](https://zcode.z.ai/) | `zcode` | Skills-based integration; installs skills into `.zcode/skills/` and invokes them as `$speckit-<command>` |

‎src/specify_cli/integrations/shai/__init__.py‎

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -36,13 +36,15 @@ def build_exec_args(
3636
integration_options: Mapping[str, Any] | None = None,
3737
project_root: Path | None = None,
3838
) -> list[str] | None:
39-
# SHAI has no argv form that runs a prompt. Its CLI collects every
40-
# argument, `-p` and `--model` included, as text for its auto-fix
41-
# agent (`trailing_var_arg`/`allow_hyphen_values` in
42-
# shai-cli/src/main.rs of ovh/shai), which then exits 0, so the
43-
# inherited `shai -p <prompt>` let workflow steps report success
44-
# without running the command (#2416). Headless prompts are read from
45-
# stdin only, and `.shai/commands` is never loaded, so opt out of
46-
# CLI dispatch and let those steps fail instead.
39+
# SHAI takes headless prompt text from positional arguments, stdin or
40+
# `shai agent <name> <prompt>`, but every route goes to its auto-fix
41+
# agent (`handle_fix` in shai-cli/src/main.rs of ovh/shai), and
42+
# `.shai/commands` is never loaded, so no route runs an installed
43+
# Spec Kit command. Positional arguments collect `-p` and `--model`
44+
# too (`trailing_var_arg`/`allow_hyphen_values`), so the inherited
45+
# `shai -p <prompt>` handed that literal text to the auto-fix agent,
46+
# which exits 0, and workflow steps reported success without running
47+
# the command (#2416). Opt out of CLI dispatch and let those steps
48+
# fail instead.
4749
self.validate_runtime_config(integration_args, integration_options)
4850
return None

‎tests/integrations/test_integration_shai.py‎

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,12 @@ class TestShaiIntegration(MarkdownIntegrationTests):
1818

1919

2020
class TestShaiCliDispatch:
21-
"""SHAI has no argv form that runs a prompt (#2416).
21+
"""SHAI's CLI can't run an installed Spec Kit command (#2416).
2222
23-
Its CLI treats every argument, `-p` included, as text for its auto-fix
24-
agent and exits 0, so dispatching `shai -p <prompt>` marked workflow steps
25-
completed without running the command.
23+
Its argument, stdin and `shai agent <name> <prompt>` routes all hand the
24+
text to its auto-fix agent, which exits 0, and `.shai/commands` is never
25+
loaded, so dispatching `shai -p <prompt>` marked workflow steps completed
26+
without running the command.
2627
"""
2728

2829
def test_build_exec_args_opts_out(self):

0 commit comments

Comments
 (0)