Allow --user-data-dir to be set in launcher properties#65
Allow --user-data-dir to be set in launcher properties#65dignifiedquire merged 2 commits intokarma-runner:masterfrom
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it! |
|
CLAs look good, thanks! |
|
Thanks, can you change the commit message to follow our convention then I can merge it :) |
Introduce a new parameter to custom launder properties: `chromeUserDir` which allows to set the `--user-data-dir` command line option to point to a specific place. Rationale: Sometimes it is useful to run Chrome under Karma with certain plugins loaded. One use-case is to have the **JetBrains IDE Support** plugin to attach the IntelliJ debugger. We can do it with `--load-extension` but this can also be prohibited by corporate policy. So one way to solve it is to have the `--user-data-dir` point to a project subdirectory and to install the plugin manually on the first run. It is preserved of course on subsequent runs.
antigremlin
force-pushed
the
release/0.2
branch
from
fa6f9bc to
72d8de4
Compare
antigremlin
changed the title
--user-data-dir to be set in custom launcher properties
|
@dignifiedquire I think this you haven't noticed that the commit messages in this PR were corrected. Do you think you could merge this? |
|
Thanks |
(yeah there are no notifications from github for pushes to PRs :( )Allow --user-data-dir to be set in launcher properties
|
@antigremlin @dignifiedquire The fix is not published on NPM i tried pulling it and found out that the modifications made to the index.js are not present within the package that is installed from NPM. Which is problematic to say the least. |
|
New version is out |
|
A perfect thanks @dignifiedquire |
4 participants
Add a new
chromeDataDirproperty to explicitly set the Chrome datadirectory. Rationale:
Sometimes it is useful to run Chrome under Karma with certain plugins
loaded. One use-case is to have the JetBrains IDE Support plugin to
attach the IntelliJ debugger. We can do it with
--load-extensionbutthis can also be prohibited by corporate policy. So one way to solve it
is to have the
--user-data-dirpoint to a project subdirectory and toinstall the plugin manually on the first run. It is preserved of course
on subsequent runs.