feat: add ChromiumHeadless#135
Merged
rogeriopvl merged 1 commit intokarma-runner:masterfrom Jun 12, 2017
ishitatsuyuki:chromium-headless
Merged
feat: add ChromiumHeadless#135rogeriopvl merged 1 commit intokarma-runner:masterfrom ishitatsuyuki:chromium-headless
rogeriopvl merged 1 commit intokarma-runner:masterfrom
ishitatsuyuki:chromium-headless
Conversation
Collaborator
|
Thanks for the PR @ishitatsuyuki 👍 The specs are failing because of npm errors about not being compatible with node versions 0.10 and 0.12. So it should be ok to merge this. I'm just going to fix this before merging. |
Contributor
Author
|
@rogeriopvl can you fix the CI ASAP, or just merge this for the meanwhile? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throughly tested. Didn't touch Dartium since I have no idea how active is it (or supported headless or not).
Fix #127