Skip to content

fix: add disable-renderer-backgrounding flag#124

Merged
rogeriopvl merged 1 commit intokarma-runner:masterfrom
cexbrayat:feat/disable-renderer-backgrounding
May 5, 2017
Merged

fix: add disable-renderer-backgrounding flag#124
rogeriopvl merged 1 commit intokarma-runner:masterfrom
cexbrayat:feat/disable-renderer-backgrounding

Conversation

@cexbrayat
Copy link
Copy Markdown
Contributor

Fixes #123

@rogeriopvl
Copy link
Copy Markdown
Collaborator

@cexbrayat thanks for the PR.

From what I understand, it should be enough to just use the --disable-background-timer-throttling flag, but on OSX it's not and it needs the --disable-renderer-backgrounding to completely disable that behaviour. Is it correct? If it is, then we need a comment documenting this work around.

I've been able to run a test suite with this flag and can confirm that there are performance gains that justify merging this.

@cexbrayat cexbrayat force-pushed the feat/disable-renderer-backgrounding branch from 5d19ff8 to 6bfc170 Compare May 5, 2017 12:32
@cexbrayat
Copy link
Copy Markdown
Contributor Author

@rogeriopvl Thank you for considering this. You're correct, this only improves performance on OSX (https://bugs.chromium.org/p/chromium/issues/detail?id=605498#c1 is probably the Chrome related issue).

I added a comment to document the workaround, let me know if that's enough.

@rogeriopvl
Copy link
Copy Markdown
Collaborator

@cexbrayat looks good 👍

@rogeriopvl rogeriopvl merged commit 0db9489 into karma-runner:master May 5, 2017
@rogeriopvl
Copy link
Copy Markdown
Collaborator

@dignifiedquire we should do a patch release

@dignifiedquire
Copy link
Copy Markdown
Member

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants