chore(linter): switch from eslint to standard#108
Merged
rogeriopvl merged 1 commit intomasterfrom Mar 15, 2017
Merged
Conversation
rogeriopvl
force-pushed
the
switch-from-eslint-to-standard
branch
2 times, most recently
from
0d497df to
c3f1967
Compare
Collaborator
Author
|
cc @dignifiedquire I would like to have some feedback for this change before merging. |
| @@ -1,5 +1,7 @@ | |||
| /* global describe, it */ | |||
Member
There was a problem hiding this comment.
please use /* eslint-env mocha */ instead
| "description": "A Karma plugin. Launcher for Chrome and Chrome Canary.", | ||
| "main": "index.js", | ||
| "scripts": { | ||
| "pretest": "standard", |
Member
There was a problem hiding this comment.
lets add a script called lint which runs standard so it's easy to run by itself
We are currently using eslint with standard plugin for linting the project's code. This is practically the same as using standard alone, and has the advantage of not needing all the eslint packages, resulting in a lot less setup and noise from greenkeeper. Standard version was downgraded to v7.1.2 to maintain compatiblity with supported node engines.
rogeriopvl
force-pushed
the
switch-from-eslint-to-standard
branch
from
c3f1967 to
51dd27b
Compare
Collaborator
Author
|
@dignifiedquire made the changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are currently using eslint with standard plugin for linting the
project's code. This is practically the same as using standard alone,
and has the advantage of not needing all the eslint packages, resulting
in a lot less setup and noise from greenkeeper.
Note: standard version was downgraded to
v7.1.2to maintain compatibility with supported node engines.