feat: allow passing custom flags

vojtajina · vojtajina · commit 4ebc76948909 · 2013-06-23T22:06:48.000-07:00
diff --git a/index.js b/index.js
@@ -1,6 +1,8 @@
-var ChromeBrowser = function(baseBrowserDecorator) {
+var ChromeBrowser = function(baseBrowserDecorator, args) {
   baseBrowserDecorator(this);
 
+  var flags = args.flags || [];
+
   this._getOptions = function(url) {
     // Chrome CLI options
     // http://peter.sh/experiments/chromium-command-line-switches/
@@ -9,9 +11,8 @@ var ChromeBrowser = function(baseBrowserDecorator) {
       '--no-default-browser-check',
       '--no-first-run',
       '--disable-default-apps',
-      '--start-maximized',
-      url
-    ];
+      '--start-maximized'
+    ].concat(flags, [url]);
   };
 };
 
@@ -26,11 +27,11 @@ ChromeBrowser.prototype = {
   ENV_CMD: 'CHROME_BIN'
 };
 
-ChromeBrowser.$inject = ['baseBrowserDecorator'];
+ChromeBrowser.$inject = ['baseBrowserDecorator', 'args'];
 
 
-var ChromeCanaryBrowser = function(baseBrowserDecorator) {
-  ChromeBrowser.call(this, baseBrowserDecorator);
+var ChromeCanaryBrowser = function(baseBrowserDecorator, args) {
+  ChromeBrowser.call(this, baseBrowserDecorator, args);
 
   var parentOptions = this._getOptions;
   this._getOptions = function(url) {
@@ -50,7 +51,7 @@ ChromeCanaryBrowser.prototype = {
   ENV_CMD: 'CHROME_CANARY_BIN'
 };
 
-ChromeCanaryBrowser.$inject = ['baseBrowserDecorator'];
+ChromeCanaryBrowser.$inject = ['baseBrowserDecorator', 'args'];
 
 
 // PUBLISH DI MODULE
diff --git a/package.json b/package.json
@@ -18,7 +18,7 @@
   "author": "Vojta Jina <vojta.jina@gmail.com>",
   "dependencies": {},
   "peerDependencies": {
-    "karma": "~0.9"
+    "karma": "~0.9.3"
   },
   "license": "MIT"
 }

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@`
`18`	`18`	`"author": "Vojta Jina <[email protected]>",`
`19`	`19`	`"dependencies": {},`
`20`	`20`	`"peerDependencies": {`
`21`		`- "karma": "~0.9"`
	`21`	`+ "karma": "~0.9.3"`
`22`	`22`	`},`
`23`	`23`	`"license": "MIT"`
`24`	`24`	`}`