Skip to content

feat(init): install coffee-script automatically#1164

Merged
maksimr merged 1 commit intokarma-runner:masterfrom
cironunes:coffee
Aug 21, 2014
Merged

feat(init): install coffee-script automatically#1164
maksimr merged 1 commit intokarma-runner:masterfrom
cironunes:coffee

Conversation

@cironunes
Copy link
Copy Markdown
Member

if the user initialize Karma passing a .coffee file we'll install
coffee-script and put it as a dev-dependency

Closes #1152

Comment thread lib/init.js Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why you remove $ from RegExp?)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @maksimr. I put it back

@maksimr
Copy link
Copy Markdown
Contributor

maksimr commented Aug 20, 2014

LGTM

Comment thread lib/init.js Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, have you gave a look to path.extname?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is cool! Haven't heard about this one before.

I'm going to update this PR later today.

Thanks, @aymericbeaumet

if the user initialize Karma passing a .coffee file we'll install
coffee-script and put it as a dev-dependency

Closes karma-runner#1152
@aymericbeaumet
Copy link
Copy Markdown
Member

LGTM

maksimr added a commit that referenced this pull request Aug 21, 2014
feat(init): install coffee-script automatically
@maksimr maksimr merged commit 1741924 into karma-runner:master Aug 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

karma init should install coffee-script (when generating karma.conf.coffee)

3 participants