-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Comparing changes
Open a pull request
base repository: karma-runner/karma
base: db53785
head repository: karma-runner/karma
compare: c1befa0
- 7 commits
- 10 files changed
- 3 contributors
Commits on Feb 1, 2022
-
fix(security): remove XSS vulnerability in
returnUrlquery paramThe `returnUrl` query parameter can be used to execute malicious code. For example, visiting `http://localhost:9876/?return_url=javascript:alert(document.domain)` will display an alert.
Jonathan Ginsburg committedFeb 1, 2022 Configuration menu - View commit details
-
Copy full SHA for 839578c - Browse repository at this point
Copy the full SHA 839578cView commit details
Commits on Feb 3, 2022
-
fix: warn when
singleRunandautoWatcharefalseSetting `singleRun` and `autoWatch` to `false` will not immediately run anything. Warn the user about this.
Jonathan Ginsburg committedFeb 3, 2022 Configuration menu - View commit details
-
Copy full SHA for 69cfc76 - Browse repository at this point
Copy the full SHA 69cfc76View commit details
Commits on Feb 5, 2022
-
fix: remove string template from client code
It is incompatible with IE.
Jonathan Ginsburg committedFeb 5, 2022 Configuration menu - View commit details
-
Copy full SHA for 91d5acd - Browse repository at this point
Copy the full SHA 91d5acdView commit details -
Configuration menu - View commit details
-
Copy full SHA for c97e562 - Browse repository at this point
Copy the full SHA c97e562View commit details -
ci: prevent duplicate CI tasks on creating a PR
BrowserStack can be flaky when there are multiple concurrent jobs running on it. This commit makes sure that only 1 browser can run concurrently during the `npm run test:client` jobs and that the "Test" GitHub Action workflow is only trigerred once when creating a PR; having the `on: push` configuration made it so that GH triggers two duplicate jobs when a PR is opened.
Jonathan Ginsburg committedFeb 5, 2022 Configuration menu - View commit details
-
Copy full SHA for 653c762 - Browse repository at this point
Copy the full SHA 653c762View commit details -
fix(helper): make mkdirIfNotExists helper resilient to concurrent calls
The main motivation for this change is karma-runner/karma-coverage#434 (comment) where concurrent calls to the helper fail because of the race between the check and directory creation. This is a temporary solution and should be replaced with the native [`mkdir`](https://nodejs.org/api/fs.html#fsmkdirpath-options-callback) with the `recursive` option once minimum supported Node is bumped to 12.
Configuration menu - View commit details
-
Copy full SHA for d9dade2 - Browse repository at this point
Copy the full SHA d9dade2View commit details -
chore(release): 6.3.15 [skip ci]
## [6.3.15](v6.3.14...v6.3.15) (2022-02-05) ### Bug Fixes * **helper:** make mkdirIfNotExists helper resilient to concurrent calls ([d9dade2](d9dade2)), closes [/github.com/karma-runner/karma-coverage/issues/434#issuecomment-1017939333](https://github.com//github.com/karma-runner/karma-coverage/issues/434/issues/issuecomment-1017939333)
Configuration menu - View commit details
-
Copy full SHA for c1befa0 - Browse repository at this point
Copy the full SHA c1befa0View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff db53785...c1befa0