refactor: replace deprecated String.prototype.substr()

CommanderRoot · Jonathan Ginsburg · commit d6359a7160ed · 2022-03-27T10:00:42.000-06:00
.substr() is deprecated so we replace it with .slice() which works similarily but isn't deprecated

Signed-off-by: Tobias Speicher &lt;rootcommander@gmail.com&gt;
diff --git a/client/main.js b/client/main.js
@@ -15,7 +15,7 @@ var socket = io(location.host, {
   reconnectionDelay: 500,
   reconnectionDelayMax: Infinity,
   timeout: BROWSER_SOCKET_TIMEOUT,
-  path: KARMA_PROXY_PATH + KARMA_URL_ROOT.substr(1) + 'socket.io',
+  path: KARMA_PROXY_PATH + KARMA_URL_ROOT.slice(1) + 'socket.io',
   'sync disconnect on unload': true,
   useNativeTimers: true
 })
diff --git a/common/util.js b/common/util.js
@@ -20,7 +20,7 @@ exports.isDefined = function (value) {
 
 exports.parseQueryParams = function (locationSearch) {
   var params = {}
-  var pairs = locationSearch.substr(1).split('&')
+  var pairs = locationSearch.slice(1).split('&')
   var keyValue
 
   for (var i = 0; i < pairs.length; i++) {
diff --git a/lib/completion.js b/lib/completion.js
@@ -36,7 +36,7 @@ const options = {
 
 function opositeWord (word) {
   if (word.startsWith('-')) {
-    return word.startsWith('--no-') ? `--${word.substr(5)}` : `--no-${word.substr(2)}`
+    return word.startsWith('--no-') ? `--${word.slice(5)}` : `--no-${word.slice(2)}`
   } else {
     return null
   }
diff --git a/lib/events.js b/lib/events.js
@@ -35,7 +35,7 @@ class KarmaEventEmitter extends EventEmitter {
   bind (object) {
     for (const method in object) {
       if (method.startsWith('on') && helper.isFunction(object[method])) {
-        this.on(helper.camelToSnake(method.substr(2)), function () {
+        this.on(helper.camelToSnake(method.slice(2)), function () {
           // We do not use an arrow function here, to supply the caller as this.
           object[method].apply(object, Array.from(arguments).concat(this))
         })
diff --git a/lib/helper.js b/lib/helper.js
@@ -96,7 +96,7 @@ exports.camelToSnake = (camelCase) => {
 }
 
 exports.ucFirst = (word) => {
-  return word.charAt(0).toUpperCase() + word.substr(1)
+  return word.charAt(0).toUpperCase() + word.slice(1)
 }
 
 exports.dashToCamel = (dash) => {
diff --git a/lib/launcher.js b/lib/launcher.js
@@ -60,7 +60,7 @@ class Launcher {
       protocol = upstreamProxy.protocol
       hostname = upstreamProxy.hostname
       port = upstreamProxy.port
-      urlRoot = upstreamProxy.path + urlRoot.substr(1)
+      urlRoot = upstreamProxy.path + urlRoot.slice(1)
     }
 
     return (name) => {
diff --git a/lib/middleware/karma.js b/lib/middleware/karma.js
@@ -32,9 +32,9 @@ const FILE_TYPES = [
 
 function filePathToUrlPath (filePath, basePath, urlRoot, proxyPath) {
   if (filePath.startsWith(basePath)) {
-    return proxyPath + urlRoot.substr(1) + 'base' + filePath.substr(basePath.length)
+    return proxyPath + urlRoot.slice(1) + 'base' + filePath.slice(basePath.length)
   }
-  return proxyPath + urlRoot.substr(1) + 'absolute' + filePath
+  return proxyPath + urlRoot.slice(1) + 'absolute' + filePath
 }
 
 function getQuery (urlStr) {
@@ -85,8 +85,8 @@ function createKarmaMiddleware (
     const requestedRangeHeader = request.headers.range
 
     // redirect /__karma__ to /__karma__ (trailing slash)
-    if (requestUrl === urlRoot.substr(0, urlRoot.length - 1)) {
-      response.setHeader('Location', proxyPath + urlRoot.substr(1))
+    if (requestUrl === urlRoot.slice(0, -1)) {
+      response.setHeader('Location', proxyPath + urlRoot.slice(1))
       response.writeHead(301)
       return response.end('MOVED PERMANENTLY')
     }
@@ -97,7 +97,7 @@ function createKarmaMiddleware (
     }
 
     // remove urlRoot prefix
-    requestUrl = requestUrl.substr(urlRoot.length - 1)
+    requestUrl = requestUrl.slice(urlRoot.length - 1)
 
     // serve client.html
     if (requestUrl === '/') {
diff --git a/lib/runner.js b/lib/runner.js
@@ -18,9 +18,9 @@ function parseExitCode (buffer, defaultExitCode, failOnEmptyTestSuite) {
 
   const tail = buffer.slice(tailPos)
   const tailStr = tail.toString()
-  if (tailStr.substr(0, tailStr.length - 2) === constant.EXIT_CODE) {
-    const emptyInt = parseInt(tailStr.substr(-2, 1), 10)
-    let exitCode = parseInt(tailStr.substr(-1), 10)
+  if (tailStr.slice(0, -2) === constant.EXIT_CODE) {
+    const emptyInt = parseInt(tailStr.slice(-2, -1), 10)
+    let exitCode = parseInt(tailStr.slice(-1), 10)
     if (failOnEmptyTestSuite === false && emptyInt === 0) {
       log.warn('Test suite was empty.')
       exitCode = 0

Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ const options = {`
`36`	`36`
`37`	`37`	`function opositeWord (word) {`
`38`	`38`	`if (word.startsWith('-')) {`
`39`		- return word.startsWith('--no-') ? `--${word.substr(5)}` : `--no-${word.substr(2)}`
	`39`	+ return word.startsWith('--no-') ? `--${word.slice(5)}` : `--no-${word.slice(2)}`
`40`	`40`	`} else {`
`41`	`41`	`return null`
`42`	`42`	`}`
Original file line number	Diff line number	Diff line change
`@@ -96,7 +96,7 @@ exports.camelToSnake = (camelCase) => {`
`96`	`96`	`}`
`97`	`97`
`98`	`98`	`exports.ucFirst = (word) => {`
`99`		`- return word.charAt(0).toUpperCase() + word.substr(1)`
	`99`	`+ return word.charAt(0).toUpperCase() + word.slice(1)`
`100`	`100`	`}`
`101`	`101`
`102`	`102`	`exports.dashToCamel = (dash) => {`
Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@ class Launcher {`
`60`	`60`	`protocol = upstreamProxy.protocol`
`61`	`61`	`hostname = upstreamProxy.hostname`
`62`	`62`	`port = upstreamProxy.port`
`63`		`- urlRoot = upstreamProxy.path + urlRoot.substr(1)`
	`63`	`+ urlRoot = upstreamProxy.path + urlRoot.slice(1)`
`64`	`64`	`}`
`65`	`65`
`66`	`66`	`return (name) => {`