fix(BaseReporter): log message correctly with just one browser (#3045)

Teamop · johnjbarton · commit c1eb236523f8 · 2018-06-15T09:00:39.000-07:00
diff --git a/lib/reporters/base.js b/lib/reporters/base.js
@@ -136,7 +136,7 @@ const BaseReporter = function (formatError, reportSlow, useColors, browserConsol
   }
 
   this.onRunComplete = (browsers, results) => {
-    if (browsers.length > 1 && !results.error && !results.disconnected) {
+    if (browsers.length >= 1 && !results.error && !results.disconnected) {
       if (!results.failed) {
         this.write(this.TOTAL_SUCCESS, results.success)
       } else {
diff --git a/test/unit/reporters/base.spec.js b/test/unit/reporters/base.spec.js
@@ -3,7 +3,7 @@
 describe('reporter', () => {
   const BaseReporter = require('../../../lib/reporters/base')
 
-  describe('Progress', () => {
+  describe('Base', () => {
     let reporter
     let adapter = reporter = null
 
@@ -181,13 +181,21 @@ describe('reporter', () => {
       return writeSpy.should.have.been.called
     })
 
-    return it('should format log messages correctly for multi browsers', () => {
+    it('should format log messages correctly for multi browsers', () => {
       const writeSpy = sinon.spy(reporter, 'writeCommonMsg')
 
       reporter._browsers = ['Chrome', 'Firefox']
       reporter.onBrowserLog('Chrome', 'Message', 'LOG')
 
       return expect(writeSpy).to.have.been.calledWith('Chrome LOG: Message\n')
     })
+
+    it('should log messages correctly when complete with just one browser', () => {
+      const writeSpy = sinon.spy(reporter, 'write')
+      const mockResults = {error: false, disconnected: false}
+
+      reporter.onRunComplete(['Chrome'], mockResults)
+      return writeSpy.should.have.been.called
+    })
   })
 })

Original file line number	Diff line number	Diff line change
`@@ -136,7 +136,7 @@ const BaseReporter = function (formatError, reportSlow, useColors, browserConsol`
`136`	`136`	`}`
`137`	`137`
`138`	`138`	`this.onRunComplete = (browsers, results) => {`
`139`		`- if (browsers.length > 1 && !results.error && !results.disconnected) {`
	`139`	`+ if (browsers.length >= 1 && !results.error && !results.disconnected) {`
`140`	`140`	`if (!results.failed) {`
`141`	`141`	`this.write(this.TOTAL_SUCCESS, results.success)`
`142`	`142`	`} else {`