Skip to content

Commit b490985

Browse files
fix(deps): Upgrade connect 3.
This means dropping support for node 0.8. Fixes part of #1410
1 parent d5dac1f commit b490985

5 files changed

Lines changed: 6 additions & 10 deletions

File tree

.travis.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ node_js:
33
- "iojs"
44
- "0.12"
55
- "0.10"
6-
- "0.8"
76

87
env:
98
global:

lib/middleware/common.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ var setNoCacheHeaders = function(response) {
8383

8484

8585
var setHeavyCacheHeaders = function(response) {
86-
response.setHeader('Cache-Control', ['public', 'max-age=31536000']);
86+
response.setHeader('Cache-Control', 'public, max-age=31536000');
8787
};
8888

8989

lib/middleware/runner.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ var path = require('path');
88
var helper = require('../helper');
99
var log = require('../logger').create();
1010
var constant = require('../constants');
11-
var json = require('connect').json();
11+
var json = require('body-parser').json();
1212

1313
// TODO(vojta): disable when single-run mode
1414
var createRunnerMiddleware = function(emitter, fileList, capturedBrowsers, reporter, executor,

lib/middleware/source_files.js

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44

55
var querystring = require('querystring');
66
var common = require('./common');
7-
var pause = require('connect').utils.pause;
87

98

109
var findByPath = function(files, path) {
@@ -29,10 +28,7 @@ var createSourceFilesMiddleware = function(filesPromise, serveFile,
2928
.replace(/^\/absolute/, '')
3029
.replace(/^\/base/, basePath);
3130

32-
// Need to pause the request because of proxying, see:
33-
// https://groups.google.com/forum/#!topic/q-continuum/xr8znxc_K5E/discussion
34-
// TODO(vojta): remove once we don't care about Node 0.8
35-
var pausedRequest = pause(request);
31+
request.pause();
3632

3733
return filesPromise.then(function(files) {
3834
// TODO(vojta): change served to be a map rather then an array
@@ -52,7 +48,7 @@ var createSourceFilesMiddleware = function(filesPromise, serveFile,
5248
next();
5349
}
5450

55-
pausedRequest.resume();
51+
request.resume();
5652
});
5753
};
5854
};

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,9 +194,10 @@
194194
"Jeff Lage <[email protected]>"
195195
],
196196
"dependencies": {
197+
"body-parser": "^1.12.4",
197198
"chokidar": "^1.0.1",
198199
"colors": "^1.1.0",
199-
"connect": "^2.29.2",
200+
"connect": "^3.3.5",
200201
"di": "^0.0.1",
201202
"expand-braces": "^0.1.1",
202203
"glob": "^5.0.6",

0 commit comments

Comments
 (0)