fix(middleware): Obey the Promise API.

johnjbarton · lusarz · commit 93ba05ad476e · 2018-07-12T10:13:03.000+02:00
Rather than catching and discarding the error if no error handler is passed, let the promise package chain it. This allows use to have a .catch() follow the then().
diff --git a/lib/middleware/common.js b/lib/middleware/common.js
@@ -16,8 +16,7 @@ class PromiseContainer {
   }
 
   then (success, error) {
-    error = error || _.noop
-    return this.promise.then(success).catch(error)
+    return this.promise.then(success, error)
   }
 
   set (newPromise) {

Original file line number	Diff line number	Diff line change
`@@ -16,8 +16,7 @@ class PromiseContainer {`
`16`	`16`	`}`
`17`	`17`
`18`	`18`	`then (success, error) {`
`19`		`- error = error \|\| _.noop`
`20`		`- return this.promise.then(success).catch(error)`
	`19`	`+ return this.promise.then(success, error)`
`21`	`20`	`}`
`22`	`21`
`23`	`22`	`set (newPromise) {`