fix(helper): Ensure browser detection is handled in the unkown case

dignifiedquire · dignifiedquire · commit 9328f67e20e4 · 2015-06-19T23:24:33.000+02:00
diff --git a/lib/helper.js b/lib/helper.js
@@ -6,7 +6,8 @@ var Promise = require('bluebird')
 
 exports.browserFullNameToShort = function (fullName) {
   var agent = useragent.parse(fullName)
-  return agent.family !== 'Other' ? agent.toAgent() + ' (' + agent.os + ')' : fullName
+  var isKnown = agent.family !== 'Other' && agent.os.family !== 'Other'
+  return isKnown ? agent.toAgent() + ' (' + agent.os + ')' : fullName
 }
 
 exports.isDefined = function (value) {

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,8 @@ var Promise = require('bluebird')`
`6`	`6`
`7`	`7`	`exports.browserFullNameToShort = function (fullName) {`
`8`	`8`	`var agent = useragent.parse(fullName)`
`9`		`- return agent.family !== 'Other' ? agent.toAgent() + ' (' + agent.os + ')' : fullName`
	`9`	`+ var isKnown = agent.family !== 'Other' && agent.os.family !== 'Other'`
	`10`	`+ return isKnown ? agent.toAgent() + ' (' + agent.os + ')' : fullName`
`10`	`11`	`}`
`11`	`12`
`12`	`13`	`exports.isDefined = function (value) {`