fix(common): stringify error on 'Cannot convert a Symbol value to a string' (#2990)

Xesenix · johnjbarton · commit 65b658a8ba33 · 2018-05-28T08:47:19.000-07:00
Fixes #2856
diff --git a/common/stringify.js b/common/stringify.js
@@ -14,6 +14,8 @@ var stringify = function stringify (obj, depth) {
   }
 
   switch (typeof obj) {
+    case 'symbol':
+      return obj.toString()
     case 'string':
       return "'" + obj + "'"
     case 'undefined':
diff --git a/test/client/stringify.spec.js b/test/client/stringify.spec.js
@@ -4,6 +4,10 @@ var assert = require('assert')
 var stringify = require('../../common/stringify')
 
 describe('stringify', function () {
+  it('should serialize symbols', function () {
+    assert.deepEqual(stringify(Symbol.for('x')), 'Symbol(x)')
+  })
+
   it('should serialize string', function () {
     assert.deepEqual(stringify('aaa'), "'aaa'")
   })

Original file line number	Diff line number	Diff line change
`@@ -14,6 +14,8 @@ var stringify = function stringify (obj, depth) {`
`14`	`14`	`}`
`15`	`15`
`16`	`16`	`switch (typeof obj) {`
	`17`	`+ case 'symbol':`
	`18`	`+ return obj.toString()`
`17`	`19`	`case 'string':`
`18`	`20`	`return "'" + obj + "'"`
`19`	`21`	`case 'undefined':`