fix(server): actually call stert(). (#3062)

johnjbarton · web-flow · commit 40d836a93aa1 · 2018-06-21T07:58:13.000-07:00
Warn that the function without a test will be removed
diff --git a/lib/server.js b/lib/server.js
@@ -375,7 +375,8 @@ class Server extends KarmaEventEmitter {
   }
 
   static start (cliOptions, done) {
-    return new Server(cliOptions, done)
+    console.warn('Deprecated static method to be removed in v3.0')
+    return new Server(cliOptions, done).start()
   }
 }
 
diff --git a/test/unit/server.spec.js b/test/unit/server.spec.js
@@ -241,8 +241,4 @@ describe('server', () => {
       }
     })
   })
-
-  it('static Server constructs a server', () => {
-    expect(Server.start(mockConfig) instanceof Server).to.be.true
-  })
 })

Original file line number	Diff line number	Diff line change
`@@ -375,7 +375,8 @@ class Server extends KarmaEventEmitter {`
`375`	`375`	`}`
`376`	`376`
`377`	`377`	`static start (cliOptions, done) {`
`378`		`- return new Server(cliOptions, done)`
	`378`	`+ console.warn('Deprecated static method to be removed in v3.0')`
	`379`	`+ return new Server(cliOptions, done).start()`
`379`	`380`	`}`
`380`	`381`	`}`
`381`	`382`
Original file line number	Diff line number	Diff line change
`@@ -241,8 +241,4 @@ describe('server', () => {`
`241`	`241`	`}`
`242`	`242`	`})`
`243`	`243`	`})`
`244`		`-`
`245`		`- it('static Server constructs a server', () => {`
`246`		`- expect(Server.start(mockConfig) instanceof Server).to.be.true`
`247`		`- })`
`248`	`244`	`})`