fix(client): serialise DOM objects

dignifiedquire · dignifiedquire · commit 1f73be4f9441 · 2015-07-03T10:16:24.000+02:00
DOM elements and nodes are now serialised using dom-serrialize. Closes #1106
diff --git a/client/stringify.js b/client/stringify.js
@@ -1,3 +1,4 @@
+var serialize = require('dom-serialize')
 var instanceOf = require('./util').instanceOf
 
 var stringify = function stringify (obj, depth) {
@@ -37,6 +38,8 @@ var stringify = function stringify (obj, depth) {
         return '<!--' + obj.nodeValue + '-->'
       } else if (obj.outerHTML) {
         return obj.outerHTML
+      } else if (obj.tagName || obj.nodeName) {
+        return serialize(obj)
       } else {
         var constructor = 'Object'
         if (obj.constructor && typeof obj.constructor === 'function') {
diff --git a/package.json b/package.json
@@ -205,6 +205,7 @@
     "connect": "^3.3.5",
     "core-js": "^0.9.17",
     "di": "^0.0.1",
+    "dom-serialize": "^2.2.0",
     "expand-braces": "^0.1.1",
     "glob": "^5.0.10",
     "graceful-fs": "^3.0.6",
diff --git a/test/client/.eslintrc b/test/client/.eslintrc
@@ -1,5 +1,6 @@
 {
   "env": {
-    "jasmine": true
+    "jasmine": true,
+    "browser": true
   }
 }
diff --git a/test/client/stringify.spec.js b/test/client/stringify.spec.js
@@ -61,6 +61,12 @@ describe('stringify', function () {
     expect(stringify(div)).to.be.eql('<div>some <span>text</span></div>')
   })
 
+  it('should serialize DOMParser objects', function () {
+    var parser = new DOMParser()
+    var doc = parser.parseFromString('<test></test>', 'application/xml')
+    expect(stringify(doc)).to.be.eql('<test></test>')
+  })
+
   it('should serialize across iframes', function () {
     var div = document.createElement('div')
     expect(__karma__.stringify(div)).to.be.eql('<div></div>')

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"env": {`
`3`		`- "jasmine": true`
	`3`	`+ "jasmine": true,`
	`4`	`+ "browser": true`
`4`	`5`	`}`
`5`	`6`	`}`