refactor: replace .substring() with .slice()

CommanderRoot · Jonathan Ginsburg · commit 1b6ded580212 · 2022-03-27T10:00:42.000-06:00
.slice() is shorter and generally faster

Signed-off-by: Tobias Speicher &lt;rootcommander@gmail.com&gt;
diff --git a/lib/file.js b/lib/file.js
@@ -36,7 +36,7 @@ class File {
    * @returns {string} detected file type or empty string
    */
   detectType () {
-    return path.extname(this.path).substring(1)
+    return path.extname(this.path).slice(1)
   }
 
   toString () {
diff --git a/lib/helper.js b/lib/helper.js
@@ -30,15 +30,15 @@ const parser = (pattern, out) => {
       t = 'optional'
     }
     out[t]++
-    return parser(pattern.substring(1), out)
+    return parser(pattern.slice(1), out)
   }
   if (matches[2] !== undefined) {
     out.ext_glob++
     parser(matches[2], out)
-    return parser(pattern.substring(matches[0].length), out)
+    return parser(pattern.slice(matches[0].length), out)
   }
   out.range++
-  return parser(pattern.substring(matches[0].length), out)
+  return parser(pattern.slice(matches[0].length), out)
 }
 
 const gsParser = (pattern, out) => {
diff --git a/lib/launchers/process.js b/lib/launchers/process.js
@@ -44,7 +44,7 @@ function ProcessLauncher (spawn, tempDir, timer, processKillTimeout) {
   // Normalize the command, remove quotes (spawn does not like them).
   this._normalizeCommand = function (cmd) {
     if (cmd.charAt(0) === cmd.charAt(cmd.length - 1) && '\'`"'.includes(cmd.charAt(0))) {
-      cmd = cmd.substring(1, cmd.length - 1)
+      cmd = cmd.slice(1, -1)
       log.warn(`The path should not be quoted.\n  Normalized the path to ${cmd}`)
     }
 
diff --git a/lib/url.js b/lib/url.js
@@ -19,7 +19,7 @@ class Url {
    * @returns {string} detected file type or empty string
    */
   detectType () {
-    return path.extname(new URL(this.path).pathname).substring(1)
+    return path.extname(new URL(this.path).pathname).slice(1)
   }
 
   toString () {

Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ class File {`
`36`	`36`	`* @returns {string} detected file type or empty string`
`37`	`37`	`*/`
`38`	`38`	`detectType () {`
`39`		`- return path.extname(this.path).substring(1)`
	`39`	`+ return path.extname(this.path).slice(1)`
`40`	`40`	`}`
`41`	`41`
`42`	`42`	`toString () {`
Original file line number	Diff line number	Diff line change
`@@ -30,15 +30,15 @@ const parser = (pattern, out) => {`
`30`	`30`	`t = 'optional'`
`31`	`31`	`}`
`32`	`32`	`out[t]++`
`33`		`- return parser(pattern.substring(1), out)`
	`33`	`+ return parser(pattern.slice(1), out)`
`34`	`34`	`}`
`35`	`35`	`if (matches[2] !== undefined) {`
`36`	`36`	`out.ext_glob++`
`37`	`37`	`parser(matches[2], out)`
`38`		`- return parser(pattern.substring(matches[0].length), out)`
	`38`	`+ return parser(pattern.slice(matches[0].length), out)`
`39`	`39`	`}`
`40`	`40`	`out.range++`
`41`		`- return parser(pattern.substring(matches[0].length), out)`
	`41`	`+ return parser(pattern.slice(matches[0].length), out)`
`42`	`42`	`}`
`43`	`43`
`44`	`44`	`const gsParser = (pattern, out) => {`
Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ function ProcessLauncher (spawn, tempDir, timer, processKillTimeout) {`
`44`	`44`	`// Normalize the command, remove quotes (spawn does not like them).`
`45`	`45`	`this._normalizeCommand = function (cmd) {`
`46`	`46`	if (cmd.charAt(0) === cmd.charAt(cmd.length - 1) && '\'`"'.includes(cmd.charAt(0))) {
`47`		`- cmd = cmd.substring(1, cmd.length - 1)`
	`47`	`+ cmd = cmd.slice(1, -1)`
`48`	`48`	log.warn(`The path should not be quoted.\n Normalized the path to ${cmd}`)
`49`	`49`	`}`
`50`	`50`
Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ class Url {`
`19`	`19`	`* @returns {string} detected file type or empty string`
`20`	`20`	`*/`
`21`	`21`	`detectType () {`
`22`		`- return path.extname(new URL(this.path).pathname).substring(1)`
	`22`	`+ return path.extname(new URL(this.path).pathname).slice(1)`
`23`	`23`	`}`
`24`	`24`
`25`	`25`	`toString () {`