fix: invalid characters in the headers on Node 5.6.0

thorn0 · thorn0 · commit 152337d99139 · 2016-02-10T20:28:33.000+02:00
diff --git a/lib/middleware/common.js b/lib/middleware/common.js
@@ -87,7 +87,7 @@ var createServeFile = function (fs, directory, config) {
 var setNoCacheHeaders = function (response) {
   response.setHeader('Cache-Control', 'no-cache')
   response.setHeader('Pragma', 'no-cache')
-  response.setHeader('Expires', (new Date(0)).toString())
+  response.setHeader('Expires', (new Date(0)).toUTCString())
 }
 
 var setHeavyCacheHeaders = function (response) {
diff --git a/test/unit/middleware/karma.spec.js b/test/unit/middleware/karma.spec.js
@@ -250,7 +250,7 @@ describe('middleware.karma', () => {
   })
 
   it('should send non-caching headers for context.html', (done) => {
-    var ZERO_DATE = (new Date(0)).toString()
+    var ZERO_DATE = (new Date(0)).toUTCString()
 
     includedFiles([])
 
diff --git a/test/unit/middleware/source_files.spec.js b/test/unit/middleware/source_files.spec.js
@@ -110,7 +110,7 @@ describe('middleware.source_files', function () {
   })
 
   it('should send no-caching headers for js source files without timestamps', function () {
-    var ZERO_DATE = new RegExp(new Date(0).toString().substring(0, 33).replace(/\+/, '\\+'))
+    var ZERO_DATE = new RegExp(new Date(0).toUTCString())
 
     servedFiles([
       new File('/src/some.js')

Original file line number	Diff line number	Diff line change
`@@ -87,7 +87,7 @@ var createServeFile = function (fs, directory, config) {`
`87`	`87`	`var setNoCacheHeaders = function (response) {`
`88`	`88`	`response.setHeader('Cache-Control', 'no-cache')`
`89`	`89`	`response.setHeader('Pragma', 'no-cache')`
`90`		`- response.setHeader('Expires', (new Date(0)).toString())`
	`90`	`+ response.setHeader('Expires', (new Date(0)).toUTCString())`
`91`	`91`	`}`
`92`	`92`
`93`	`93`	`var setHeavyCacheHeaders = function (response) {`