Skip to content

upgrade librdkafka to v2.0.2#242

Merged
mensfeld merged 2 commits intomainfrom
lmaia/upgrade-rdkafka-2.0.2
Jun 11, 2023
Merged

upgrade librdkafka to v2.0.2#242
mensfeld merged 2 commits intomainfrom
lmaia/upgrade-rdkafka-2.0.2

Conversation

@leonmaia
Copy link
Copy Markdown
Contributor

@leonmaia leonmaia commented Feb 8, 2023

Upgrades librdkafka to version 2.0.2, this version contains several improvements and bugfixes. For a full list of the changes please refer to https://github.com/confluentinc/librdkafka/blob/master/CHANGELOG.md

@leonmaia leonmaia force-pushed the lmaia/upgrade-rdkafka-2.0.2 branch 4 times, most recently from 46f30d8 to 17aa4b4 Compare February 8, 2023 12:11
@mensfeld
Copy link
Copy Markdown
Member

mensfeld commented Feb 8, 2023

0.13 is in beta, so I would suggest still target 0.13 with it or even 0.12.1 until we solve problems with stability in 0.13. That way this could be backported as 0.12.1 and then updated in the main. WDYT?

@leonmaia
Copy link
Copy Markdown
Contributor Author

leonmaia commented Feb 8, 2023

good call @mensfeld I'm bumping the beta count on 0.13.

@leonmaia leonmaia force-pushed the lmaia/upgrade-rdkafka-2.0.2 branch from 17aa4b4 to 604ec28 Compare February 8, 2023 14:05
@mensfeld
Copy link
Copy Markdown
Member

mensfeld commented Feb 8, 2023

@leonmaia @thijsc I think it should go to 0.12.1. 0.13.0 will change how the locks operate and I would not release it together with this. I did bump it to my fork and I executed all the integrations: works and is stable. I am crafting 0.12.1 for myself: https://github.com/karafka/karafka-rdkafka/tree/v0.12.1

@mensfeld
Copy link
Copy Markdown
Member

mensfeld commented Feb 8, 2023

Just to be clear: passes with the same crashes expected from 0.12 ;)

@mensfeld
Copy link
Copy Markdown
Member

I released it to karafka - no issues there. Works stable after bump with 0.12.

@mensfeld
Copy link
Copy Markdown
Member

@thijsc ping ;)

@mensfeld
Copy link
Copy Markdown
Member

I think this will hae to wait post 0.13.0 not to risk one more change after the native kafka lock

@mensfeld
Copy link
Copy Markdown
Member

mensfeld commented Apr 8, 2023

@leonmaia can you rebase please? 🙏

@mensfeld mensfeld self-assigned this Apr 12, 2023
@mensfeld mensfeld added the librdkafka Label for reports / issues related to C librdkafka label Apr 12, 2023
@mensfeld mensfeld mentioned this pull request Jun 8, 2023
5 tasks
@mensfeld
Copy link
Copy Markdown
Member

@thijsc lets release it with the upcoming one ok? It solves some of the rebalance problems and aligns with karafka-rdkafka releases. It is also heavily tested by me & karafka users and there are no breaking changes.

@mensfeld mensfeld merged commit 221b110 into main Jun 11, 2023
@mensfeld mensfeld deleted the lmaia/upgrade-rdkafka-2.0.2 branch June 11, 2023 17:01
@mensfeld
Copy link
Copy Markdown
Member

@leonmaia sorry it took so long. I had to clean up memory leaks and fix few other things to make sure it operates as expected.

@thijsc
Copy link
Copy Markdown
Contributor

thijsc commented Jun 12, 2023

lets release it with the upcoming one ok? I

👍

@thijsc
Copy link
Copy Markdown
Contributor

thijsc commented Jun 12, 2023

I just pushed 0.13.0.beta.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

librdkafka Label for reports / issues related to C librdkafka

Development

Successfully merging this pull request may close these issues.

3 participants