Skip to content

use commander instead of cli#602

Merged
kangax merged 1 commit into
kangax:gh-pagesfrom
alexlamsl:cli-commander
Apr 5, 2016
Merged

use commander instead of cli#602
kangax merged 1 commit into
kangax:gh-pagesfrom
alexlamsl:cli-commander

Conversation

@alexlamsl

Copy link
Copy Markdown
Collaborator

Reason for migration:

  • less dependencies
  • shares with clean-css
  • 2.5M vs 18M downloads per month
  • 353 vs 288 lines for cli.js

Also fixes a bug with minifier options mutating when processing directory as input - there is a performance penalty for this fix, which I'm looking into. the performance difference is due to the bug resulting in some options being suppressed.

@kangax

kangax commented Apr 5, 2016

Copy link
Copy Markdown
Owner

LGTM (although no experience with either)

@kangax
kangax merged commit a46b543 into kangax:gh-pages Apr 5, 2016
@alexlamsl
alexlamsl deleted the cli-commander branch April 6, 2016 02:40
@alexlamsl alexlamsl mentioned this pull request Apr 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants