Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: kamcheungting-db/iceberg-cpp
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: datafile-serde-java
Choose a base ref
...
head repository: kamcheungting-db/iceberg-cpp
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: filescan-task-serde
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 8 commits
  • 24 files changed
  • 6 contributors

Commits on Oct 11, 2026

  1. fix(expression): return a parse error for non-string type nodes in ex… 

    …pression JSON (apache#982)

IsTransformTerm, NamedReferenceFromJson, both LiteralFromJson
overloads, and ExpressionFromJson read the 'type' discriminator with
json[kType].get<std::string>() guarded only by contains(), so a
present-but-non-string 'type' (e.g. a number) threw an uncaught
nlohmann type_error out of the Result-returning parse API. Check
is_string() first, matching the sibling OperationTypeFromJson guard,
so malformed expression JSON yields JsonParseError instead of an
escaped exception.
    @LuciferYang
    LuciferYang authored Oct 11, 2026
    Configuration menu
    Copy the full SHA
    ecf3624 View commit details
    Browse the repository at this point in the history

  2. refactor: move each TableScan subclass to its own file (apache#994) 

    Move DataTableScan, IncrementalAppendScan and IncrementalChangelogScan
into data_table_scan.{h,cc}, incremental_append_scan.{h,cc} and
incremental_changelog_scan.{h,cc}. table_scan.{h,cc} keep TableScan,
IncrementalScan, TableScanBuilder, the scan task types and
TableScanContext.

Co-authored-by: Claude Opus 5.5 <[email protected]>
    @manuzhang @claude
    manuzhang and claude authored Oct 11, 2026
    Configuration menu
    Copy the full SHA
    c712948 View commit details
    Browse the repository at this point in the history

  3. fix(json): return a parse error for a list type missing 'element' (ap… 

    …ache#997)

ListTypeFromJson read the nested element type with the raw const
json[kElement] accessor, which is undefined behavior (an assertion in
debug nlohmann builds) when a list type object is missing the required
'element' key. Use GetJsonValue<nlohmann::json>(json, kElement) like
the sibling MapTypeFromJson does, so malformed schema or table-metadata
JSON yields JsonParseError instead of asserting.
    @LuciferYang
    LuciferYang authored Oct 11, 2026
    Configuration menu
    Copy the full SHA
    ed6608d View commit details
    Browse the repository at this point in the history

  4. fix(serde): make DataFile JSON compatible with Java Iceberg (apache#975)

    @kamcheungting-db
    kamcheungting-db authored Oct 11, 2026
    Configuration menu
    Copy the full SHA
    87ed963 View commit details
    Browse the repository at this point in the history

  5. feat(serde): add core FileScanTask JSON support

    @kamcheungting-db @wgtmac
    kamcheungting-db authored and wgtmac committed Oct 11, 2026
    Configuration menu
    Copy the full SHA
    78e5f66 View commit details
    Browse the repository at this point in the history

  6. fix(serde): accept historical FileScanTask specs

    @kamcheungting-db @wgtmac
    kamcheungting-db authored and wgtmac committed Oct 11, 2026
    Configuration menu
    Copy the full SHA
    cb959f5 View commit details
    Browse the repository at this point in the history

  7. test(serde): cover FileScanTask range and spec boundaries

    @kamcheungting-db @wgtmac
    kamcheungting-db authored and wgtmac committed Oct 11, 2026
    Configuration menu
    Copy the full SHA
    7bc87fb View commit details
    Browse the repository at this point in the history

  8. fix(serde): address FileScanTask JSON review feedback 

    - move the strict integer helpers (IntegerFromJson, GetJsonInteger,
  IntegerVectorFromJson) into json_util_internal.h and add
  GetJsonIntegerOrDefault there, so the REST scan-task reader reuses them
  instead of keeping a local copy
- omit 'delete-files' when the task has no delete files, matching Java
- look up the partition spec explicitly in ToJson(FileScanTask) instead of
  relying on std::map::at() after an earlier validation
    @wgtmac
    wgtmac committed Oct 11, 2026
    Configuration menu
    Copy the full SHA
    41778c9 View commit details
    Browse the repository at this point in the history
Loading