index: Fix for indexers skipping genesis block.

jimpo · jimpo · commit ed12d5df1ba5 · 2018-08-27T17:03:24.000-07:00
diff --git a/src/index/base.cpp b/src/index/base.cpp
@@ -60,7 +60,11 @@ bool BaseIndex::Init()
     }
 
     LOCK(cs_main);
-    m_best_block_index = FindForkInGlobalIndex(chainActive, locator);
+    if (locator.IsNull()) {
+        m_best_block_index = nullptr;
+    } else {
+        m_best_block_index = FindForkInGlobalIndex(chainActive, locator);
+    }
     m_synced = m_best_block_index.load() == chainActive.Tip();
     return true;
 }
diff --git a/src/index/txindex.cpp b/src/index/txindex.cpp
@@ -245,6 +245,9 @@ bool TxIndex::Init()
 
 bool TxIndex::WriteBlock(const CBlock& block, const CBlockIndex* pindex)
 {
+    // Exclude genesis block transaction because outputs are not spendable.
+    if (pindex->nHeight == 0) return true;
+
     CDiskTxPos pos(pindex->GetBlockPos(), GetSizeOfCompactSize(block.vtx.size()));
     std::vector<std::pair<uint256, CDiskTxPos>> vPos;
     vPos.reserve(block.vtx.size());
diff --git a/src/test/txindex_tests.cpp b/src/test/txindex_tests.cpp
@@ -2,6 +2,7 @@
 // Distributed under the MIT software license, see the accompanying
 // file COPYING or http://www.opensource.org/licenses/mit-license.php.
 
+#include <chainparams.h>
 #include <index/txindex.h>
 #include <script/standard.h>
 #include <test/test_bitcoin.h>
@@ -38,6 +39,12 @@ BOOST_FIXTURE_TEST_CASE(txindex_initial_sync, TestChain100Setup)
         MilliSleep(100);
     }
 
+    // Check that txindex excludes genesis block transactions.
+    const CBlock& genesis_block = Params().GenesisBlock();
+    for (const auto& txn : genesis_block.vtx) {
+        BOOST_CHECK(!txindex.FindTx(txn->GetHash(), block_hash, tx_disk));
+    }
+
     // Check that txindex has all txs that were in the chain before it started.
     for (const auto& txn : m_coinbase_txns) {
         if (!txindex.FindTx(txn->GetHash(), block_hash, tx_disk)) {

Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,11 @@ bool BaseIndex::Init()`
`60`	`60`	`}`
`61`	`61`
`62`	`62`	`LOCK(cs_main);`
`63`		`- m_best_block_index = FindForkInGlobalIndex(chainActive, locator);`
	`63`	`+ if (locator.IsNull()) {`
	`64`	`+ m_best_block_index = nullptr;`
	`65`	`+ } else {`
	`66`	`+ m_best_block_index = FindForkInGlobalIndex(chainActive, locator);`
	`67`	`+ }`
`64`	`68`	`m_synced = m_best_block_index.load() == chainActive.Tip();`
`65`	`69`	`return true;`
`66`	`70`	`}`
Original file line number	Diff line number	Diff line change
`@@ -245,6 +245,9 @@ bool TxIndex::Init()`
`245`	`245`
`246`	`246`	`bool TxIndex::WriteBlock(const CBlock& block, const CBlockIndex* pindex)`
`247`	`247`	`{`
	`248`	`+ // Exclude genesis block transaction because outputs are not spendable.`
	`249`	`+ if (pindex->nHeight == 0) return true;`
	`250`	`+`
`248`	`251`	`CDiskTxPos pos(pindex->GetBlockPos(), GetSizeOfCompactSize(block.vtx.size()));`
`249`	`252`	`std::vector<std::pair<uint256, CDiskTxPos>> vPos;`
`250`	`253`	`vPos.reserve(block.vtx.size());`