Mark single-argument constructors "explicit"

practicalswift · practicalswift · commit 1ac3c983bfe0 · 2018-07-26T17:15:32.000+02:00
diff --git a/src/interfaces/handler.cpp b/src/interfaces/handler.cpp
@@ -15,7 +15,7 @@ namespace {
 class HandlerImpl : public Handler
 {
 public:
-    HandlerImpl(boost::signals2::connection connection) : m_connection(std::move(connection)) {}
+    explicit HandlerImpl(boost::signals2::connection connection) : m_connection(std::move(connection)) {}
 
     void disconnect() override { m_connection.disconnect(); }
 
diff --git a/src/interfaces/wallet.cpp b/src/interfaces/wallet.cpp
@@ -31,7 +31,7 @@ namespace {
 class PendingWalletTxImpl : public PendingWalletTx
 {
 public:
-    PendingWalletTxImpl(CWallet& wallet) : m_wallet(wallet), m_key(&wallet) {}
+    explicit PendingWalletTxImpl(CWallet& wallet) : m_wallet(wallet), m_key(&wallet) {}
 
     const CTransaction& get() override { return *m_tx; }
 
@@ -117,7 +117,7 @@ WalletTxOut MakeWalletTxOut(CWallet& wallet, const CWalletTx& wtx, int n, int de
 class WalletImpl : public Wallet
 {
 public:
-    WalletImpl(const std::shared_ptr<CWallet>& wallet) : m_shared_wallet(wallet), m_wallet(*wallet.get()) {}
+    explicit WalletImpl(const std::shared_ptr<CWallet>& wallet) : m_shared_wallet(wallet), m_wallet(*wallet.get()) {}
 
     bool encryptWallet(const SecureString& wallet_passphrase) override
     {
diff --git a/src/key_io.cpp b/src/key_io.cpp
@@ -24,7 +24,7 @@ class DestinationEncoder : public boost::static_visitor<std::string>
     const CChainParams& m_params;
 
 public:
-    DestinationEncoder(const CChainParams& params) : m_params(params) {}
+    explicit DestinationEncoder(const CChainParams& params) : m_params(params) {}
 
     std::string operator()(const CKeyID& id) const
     {
diff --git a/src/qt/addresstablemodel.cpp b/src/qt/addresstablemodel.cpp
@@ -71,7 +71,7 @@ class AddressTablePriv
     QList<AddressTableEntry> cachedAddressTable;
     AddressTableModel *parent;
 
-    AddressTablePriv(AddressTableModel *_parent):
+    explicit AddressTablePriv(AddressTableModel *_parent):
         parent(_parent) {}
 
     void refreshAddressTable(interfaces::Wallet& wallet)
diff --git a/src/qt/rpcconsole.cpp b/src/qt/rpcconsole.cpp
@@ -82,7 +82,7 @@ class RPCExecutor : public QObject
 {
     Q_OBJECT
 public:
-    RPCExecutor(interfaces::Node& node) : m_node(node) {}
+    explicit RPCExecutor(interfaces::Node& node) : m_node(node) {}
 
 public Q_SLOTS:
     void request(const QString &command, const QString &walletID);
diff --git a/src/qt/transactiontablemodel.cpp b/src/qt/transactiontablemodel.cpp
@@ -58,7 +58,7 @@ struct TxLessThan
 class TransactionTablePriv
 {
 public:
-    TransactionTablePriv(TransactionTableModel *_parent) :
+    explicit TransactionTablePriv(TransactionTableModel *_parent) :
         parent(_parent)
     {
     }
diff --git a/src/test/miner_tests.cpp b/src/test/miner_tests.cpp
@@ -29,7 +29,7 @@ BOOST_FIXTURE_TEST_SUITE(miner_tests, TestingSetup)
 // BOOST_CHECK_EXCEPTION predicates to check the specific validation error
 class HasReason {
 public:
-    HasReason(const std::string& reason) : m_reason(reason) {}
+    explicit HasReason(const std::string& reason) : m_reason(reason) {}
     bool operator() (const std::runtime_error& e) const {
         return std::string(e.what()).find(m_reason) != std::string::npos;
     };
diff --git a/src/test/validation_block_tests.cpp b/src/test/validation_block_tests.cpp
@@ -23,7 +23,7 @@ BOOST_FIXTURE_TEST_SUITE(validation_block_tests, RegtestingSetup)
 struct TestSubscriber : public CValidationInterface {
     uint256 m_expected_tip;
 
-    TestSubscriber(uint256 tip) : m_expected_tip(tip) {}
+    explicit TestSubscriber(uint256 tip) : m_expected_tip(tip) {}
 
     void UpdatedBlockTip(const CBlockIndex* pindexNew, const CBlockIndex* pindexFork, bool fInitialDownload) override
     {

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@ namespace {`
`15`	`15`	`class HandlerImpl : public Handler`
`16`	`16`	`{`
`17`	`17`	`public:`
`18`		`- HandlerImpl(boost::signals2::connection connection) : m_connection(std::move(connection)) {}`
	`18`	`+ explicit HandlerImpl(boost::signals2::connection connection) : m_connection(std::move(connection)) {}`
`19`	`19`
`20`	`20`	`void disconnect() override { m_connection.disconnect(); }`
`21`	`21`
Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ namespace {`
`31`	`31`	`class PendingWalletTxImpl : public PendingWalletTx`
`32`	`32`	`{`
`33`	`33`	`public:`
`34`		`- PendingWalletTxImpl(CWallet& wallet) : m_wallet(wallet), m_key(&wallet) {}`
	`34`	`+ explicit PendingWalletTxImpl(CWallet& wallet) : m_wallet(wallet), m_key(&wallet) {}`
`35`	`35`
`36`	`36`	`const CTransaction& get() override { return *m_tx; }`
`37`	`37`
`@@ -117,7 +117,7 @@ WalletTxOut MakeWalletTxOut(CWallet& wallet, const CWalletTx& wtx, int n, int de`
`117`	`117`	`class WalletImpl : public Wallet`
`118`	`118`	`{`
`119`	`119`	`public:`
`120`		`- WalletImpl(const std::shared_ptr<CWallet>& wallet) : m_shared_wallet(wallet), m_wallet(*wallet.get()) {}`
	`120`	`+ explicit WalletImpl(const std::shared_ptr<CWallet>& wallet) : m_shared_wallet(wallet), m_wallet(*wallet.get()) {}`
`121`	`121`
`122`	`122`	`bool encryptWallet(const SecureString& wallet_passphrase) override`
`123`	`123`	`{`
Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ class DestinationEncoder : public boost::static_visitor<std::string>`
`24`	`24`	`const CChainParams& m_params;`
`25`	`25`
`26`	`26`	`public:`
`27`		`- DestinationEncoder(const CChainParams& params) : m_params(params) {}`
	`27`	`+ explicit DestinationEncoder(const CChainParams& params) : m_params(params) {}`
`28`	`28`
`29`	`29`	`std::string operator()(const CKeyID& id) const`
`30`	`30`	`{`
Original file line number	Diff line number	Diff line change
`@@ -82,7 +82,7 @@ class RPCExecutor : public QObject`
`82`	`82`	`{`
`83`	`83`	`Q_OBJECT`
`84`	`84`	`public:`
`85`		`- RPCExecutor(interfaces::Node& node) : m_node(node) {}`
	`85`	`+ explicit RPCExecutor(interfaces::Node& node) : m_node(node) {}`
`86`	`86`
`87`	`87`	`public Q_SLOTS:`
`88`	`88`	`void request(const QString &command, const QString &walletID);`
Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,7 @@ struct TxLessThan`
`58`	`58`	`class TransactionTablePriv`
`59`	`59`	`{`
`60`	`60`	`public:`
`61`		`- TransactionTablePriv(TransactionTableModel *_parent) :`
	`61`	`+ explicit TransactionTablePriv(TransactionTableModel *_parent) :`
`62`	`62`	`parent(_parent)`
`63`	`63`	`{`
`64`	`64`	`}`
Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@ BOOST_FIXTURE_TEST_SUITE(validation_block_tests, RegtestingSetup)`
`23`	`23`	`struct TestSubscriber : public CValidationInterface {`
`24`	`24`	`uint256 m_expected_tip;`
`25`	`25`
`26`		`- TestSubscriber(uint256 tip) : m_expected_tip(tip) {}`
	`26`	`+ explicit TestSubscriber(uint256 tip) : m_expected_tip(tip) {}`
`27`	`27`
`28`	`28`	`void UpdatedBlockTip(const CBlockIndex* pindexNew, const CBlockIndex* pindexFork, bool fInitialDownload) override`
`29`	`29`	`{`