Skip to content

fix: scrolltop button#2012

Merged
kai687 merged 2 commits intomainfrom
fix/scrolltop
Oct 4, 2024
Merged

fix: scrolltop button#2012
kai687 merged 2 commits intomainfrom
fix/scrolltop

Conversation

@kai687
Copy link
Copy Markdown
Owner

@kai687 kai687 commented Oct 4, 2024

Re-implement the show_scrolltop functionality.

I think I wanted to remove the scroll to top button with version 5, but I left in the template and configuration option. Since it was documented behavior, I treated this as a bug and re-implemented the behavior with Alpine.

Fixes #1981.

@kai687 kai687 self-assigned this Oct 4, 2024
@kai687 kai687 added the bug Something isn't working label Oct 4, 2024
@kai687 kai687 marked this pull request as ready for review October 4, 2024 15:39
@kai687 kai687 merged commit beebf4b into main Oct 4, 2024
@kai687 kai687 deleted the fix/scrolltop branch October 4, 2024 15:40
@netlify
Copy link
Copy Markdown

netlify bot commented Oct 4, 2024

Deploy Preview for sphinxawesome-theme ready!

Name Link
🔨 Latest commit 2df2ddd
🔍 Latest deploy log https://app.netlify.com/sites/sphinxawesome-theme/deploys/67000c37c08c5e00083a7704
😎 Deploy Preview https://deploy-preview-2012--sphinxawesome-theme.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

show_scrolltop not displaying

1 participant