Repository navigation
add an option to not set the api key - #389
Conversation
Signed-off-by: Peter Jausovec <[email protected]>
Signed-off-by: Peter Jausovec <[email protected]>
sbx0r
left a comment
sbx0r
left a comment
There was a problem hiding this comment.
Looks like a preparation for kgateway 😃 🚀
EItanya
left a comment
EItanya
left a comment
There was a problem hiding this comment.
I like these changes overall, I don't love a specific field in the REST API called IsGateway. Can we be more generic, or infer from the hostname?
Signed-off-by: Peter Jausovec <[email protected]>
There was a problem hiding this comment.
Wait so for this, it seems we are just deciding that if there is no key, then we must be using a gateway? That won't work tho. Because we may use a key with or without a gateway. I don't think we should just try to infer anything with this PR. We should be very explicit with an option that "ApiKeyRequired" which defaults to true, but can be overridden. Maybe for Ollama it can default to false.
There was a problem hiding this comment.
I can change the UI option to say something like "I don't need an API key" or something like that, so it's not specific to the gateway.
Signed-off-by: Peter Jausovec <[email protected]>
…to persistent-sessions * 'persistent-sessions' of github.com:kagent-dev/kagent: Docker - improve slow CI multi arch build (#398) added bug_report and version invoke with/without session works properly eitanya/fix-name-template (#399) add non-interactive CLI commands add an option to not set the api key (#389)
* add an option to not set the api key Signed-off-by: Peter Jausovec <[email protected]> * ui fix Signed-off-by: Peter Jausovec <[email protected]> * pr feedback Signed-off-by: Peter Jausovec <[email protected]> * change the text Signed-off-by: Peter Jausovec <[email protected]> --------- Signed-off-by: Peter Jausovec <[email protected]> Co-authored-by: Eitan Yarmush <[email protected]>
Fix on the UI side:
Controller: