Repository navigation
cleanup: remove unused KubeClientWrapper - #3591
Merged
timflannagan merged 1 commit intoNov 9, 2026
Merged
timflannagan merged 1 commit into
timflannagan merged 1 commit into
Conversation
Delete KubeClientWrapper. Nothing outside its own test constructs it. The wrapper overlaid unsaved objects on a controller-runtime client so the agent manifest validator could dry-run the old translator against an Agent before it existed. kagent-dev#2565 removed that validator and translator along with the legacy runtime, but left the wrapper behind. Agents now compile from KRT collections, so nothing needs to fake client reads. Signed-off-by: timflannagan <[email protected]>
cjlg-soloio
approved these changes
Nov 9, 2026
codyhartsook
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
utils.KubeClientWrapperand its test. Nothing outside its own test constructs it.The wrapper overlaid unsaved objects on a controller-runtime client so the agent manifest validator could dry-run the old translator against an Agent before it existed. #2565 removed that validator and translator with the legacy runtime but left the wrapper behind. Agents now compile from KRT collections, so nothing needs to fake client reads.
Part of #3235.