Skip to content

fix(ci): enforce protobuf compatibility after pre-RC cleanup - #3455

Merged
EItanya merged 2 commits into
refactor/remove-unused-harness-adk-fieldsfrom
fix/enforce-protobuf-compatibility
Oct 30, 2026
Merged

EItanya merged 2 commits into
refactor/remove-unused-harness-adk-fieldsfrom
fix/enforce-protobuf-compatibility

Conversation

@EItanya

@EItanya EItanya commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Stacked on #3454.

Remove all Buf breaking-change exemptions, including excluded files and unstable packages, so FILE compatibility applies after the final pre-RC cleanup.

The CI check was silently skipping compatibility validation because the checkout had no local main branch. Compare against the actual PR or merge-group base SHA, or the previous commit on push, and fail when the baseline is missing.

Validated protobuf lint, compatibility against the parent PR, and workflow lint. Confirmed that the pre-cleanup API removals and a missing baseline both fail instead of passing silently.

@github-actions github-actions Bot added the bug Something isn't working label Oct 30, 2026
@EItanya
EItanya added this pull request to stack #3456 October 30, 2026 13:03
@github-actions github-actions Bot added bug Something isn't working and removed bug Something isn't working labels Oct 30, 2026
@EItanya
EItanya force-pushed the fix/enforce-protobuf-compatibility branch from f16b1bd to f7c5857 Compare October 30, 2026 13:34
@EItanya
EItanya added this pull request to the merge queue Oct 30, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue because a pull request earlier in the stack was removed Oct 30, 2026
@EItanya
EItanya added this pull request to the merge queue Oct 30, 2026
Merged via the queue into main with commit 8f6910c Oct 30, 2026
30 checks passed
@EItanya
EItanya deleted the fix/enforce-protobuf-compatibility branch October 30, 2026 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants