Skip to content

fix(api): remove unused Harness status and ADK fields - #3454

Merged
EItanya merged 2 commits into
mainfrom
refactor/remove-unused-harness-adk-fields
Oct 30, 2026
Merged

EItanya merged 2 commits into
mainfrom
refactor/remove-unused-harness-adk-fields

Conversation

@EItanya

@EItanya EItanya commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Remove Harness.status and the derived gRPC/UI readiness field, plus ADK network, share_tools, and ADKNetworkConfig. Harness status has no writer on main, and neither ADK consumes these config fields, so drop them before the first RC.

Regenerates the CRDs and clients and removes the obsolete status RBAC, fixtures, and tests. The removed protobuf fields have no reservations, since this is the final pre-RC API break. Includes narrow Buf exceptions for these removals.

Validated code generation and compatibility checks, focused Go/CRD tests, Go lint, 87 Python config tests, 697 UI unit tests, UI typecheck/lint, the Harness flow in Chromium and Firefox, and 21 Helm RBAC tests.

Overlaps with #3340, which adds writers for the Harness status being removed here.

@EItanya
EItanya requested review from a team and supreme-gg-gg as code owners October 30, 2026 12:36
@EItanya EItanya changed the title refactor!: remove unused Harness status and ADK fields fix(api)!: remove unused Harness status and ADK fields Oct 30, 2026
@EItanya EItanya changed the title fix(api)!: remove unused Harness status and ADK fields fix(api): remove unused Harness status and ADK fields Oct 30, 2026
@github-actions github-actions Bot added the bug Something isn't working label Oct 30, 2026
@EItanya
EItanya added this pull request to stack #3456 October 30, 2026 13:03
@EItanya
EItanya force-pushed the refactor/remove-unused-harness-adk-fields branch from e5e4cc0 to 7d01227 Compare October 30, 2026 13:34
@EItanya
EItanya added this pull request to the merge queue Oct 30, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 30, 2026
@EItanya
EItanya added this pull request to the merge queue Oct 30, 2026
Merged via the queue into main with commit f329860 Oct 30, 2026
30 checks passed
@EItanya
EItanya deleted the refactor/remove-unused-harness-adk-fields branch October 30, 2026 14:55
garlicKim21 pushed a commit to garlicKim21/kagent that referenced this pull request Oct 30, 2026
…dev#3455)

Stacked on kagent-dev#3454.

Remove all Buf breaking-change exemptions, including excluded files and
unstable packages, so `FILE` compatibility applies after the final
pre-RC cleanup.

The CI check was silently skipping compatibility validation because the
checkout had no local `main` branch. Compare against the actual PR or
merge-group base SHA, or the previous commit on push, and fail when the
baseline is missing.

Validated protobuf lint, compatibility against the parent PR, and
workflow lint. Confirmed that the pre-cleanup API removals and a missing
baseline both fail instead of passing silently.

---------

Signed-off-by: Eitan Yarmush <[email protected]>
q-qp-p pushed a commit to q-qp-p/kagent that referenced this pull request Nov 8, 2026
…on a status change (kagent-dev#3340)

## Problem
The ModelConfig status writer moves a condition's `lastTransitionTime`
whenever its reason, message or observedGeneration changes. Agent
conditions, and SandboxTemplate through `apimeta.SetStatusCondition`,
move it only when the status changes, as the API conventions define it.
A ModelConfig that stays `False` therefore reports a new transition time
every time its error text or generation changes.

## Change
Agent and ModelConfig share one helper that keeps the transition time
while a condition's status holds. A new test covers a changed reason,
message and generation under an unchanged status, and a status change.

This PR previously wrote Harness `Ready`/`Booted` conditions; kagent-dev#3454
removed `Harness.status`, so it is reduced to the transition-time rule
that part shared with Agent and ModelConfig.

Signed-off-by: QuentinBisson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants