Skip to content

cleanup: Remove legacy KMCP integration - #3223

Merged
EItanya merged 2 commits into
kagent-dev:mainfrom
timflannagan:cleanup/remove-kmcp
Oct 15, 2026
Merged

EItanya merged 2 commits into
kagent-dev:mainfrom
timflannagan:cleanup/remove-kmcp

Conversation

@timflannagan

@timflannagan timflannagan commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Description

KMCP is no longer part of kagent's runtime architecture. RemoteMCPServer is
the supported Kubernetes resource, while Substrate owns runtime provisioning.

Remove the KMCP chart dependency, controller and service wiring, UI support for
MCPServer, and the KMCP-derived kagent mcp project scaffolder. Keep the
RemoteMCPServer flows intact and mark the historical KMCP design as
superseded.

The scaffolder can return in a v1-aligned form if user demand warrants it.
Today it is unmaintained KMCP-era cruft with no supported v1 deployment path,
so keeping it would imply a product surface that kagent does not actually
support.

Additional Notes

This targets clean installs. Existing upgraded clusters may retain KMCP CRDs or
resources that the kagent chart no longer manages.

Kagent now uses RemoteMCPServer as its only MCP Kubernetes API.
Remove the legacy deployment, controller, packaging, and UI paths so clean
installs no longer carry the obsolete KMCP integration.

Signed-off-by: timflannagan <[email protected]>
The MCP project scaffolder came from the legacy KMCP CLI and no longer has a
deployment path after removing that integration.

Remove the isolated init, build, run, add-tool, and secrets commands along with
their language templates and project manifest model.

Signed-off-by: timflannagan <[email protected]>
@timflannagan
timflannagan requested a review from a team as a code owner October 15, 2026 17:19
@github-actions github-actions Bot added the enhancement-proposal Indicates that this PR is for an enhancement proposal label Oct 15, 2026
@timflannagan timflannagan added ignore-for-release and removed enhancement-proposal Indicates that this PR is for an enhancement proposal labels Oct 15, 2026
@github-actions github-actions Bot added the enhancement-proposal Indicates that this PR is for an enhancement proposal label Oct 15, 2026
@timflannagan
timflannagan requested a review from EItanya October 15, 2026 17:24

@EItanya EItanya left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I definitely think we should remove it from the base helm chart and CLI , but can we hold off removing the intergration altogether for a follow-up?

@timflannagan

Copy link
Copy Markdown
Contributor Author

I definitely think we should remove it from the base helm chart and CLI , but can we hold off removing the intergration altogether for a follow-up?

Are you advocating for splitting up this PR into multiple or holding off on removing the integration for now? I think it's pretty cheap to bring back the integration via agents these days, maintaining code that's not being used also trips up agents, etc. At least that's my 2c.

@EItanya
EItanya added this pull request to the merge queue Oct 15, 2026
Merged via the queue into kagent-dev:main with commit 78800f8 Oct 15, 2026
33 checks passed
@timflannagan
timflannagan deleted the cleanup/remove-kmcp branch October 15, 2026 19:19
hsteude pushed a commit to prokube/kagent that referenced this pull request Nov 6, 2026
# Description

Removing the KMCP integration and the `kagent mcp` scaffolder in kagent-dev#3223
left the shared CLI helpers it used without callers. This removes the
Docker executor, project generator, filesystem, Kubernetes config, and
input prompt helpers, trims the kubectl executor to what `kagent
bug-report` still uses, and drops the `logging.FromLogr` adapter whose
only caller was the MCPServer catalog check.

No behavior change. The remaining `deadcode` findings are public STS
helpers and the `WithGRPCTransportCredentials` client option, which are
intentionally kept as consumer-facing extension points.

Signed-off-by: timflannagan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement-proposal Indicates that this PR is for an enhancement proposal ignore-for-release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants