Skip to content

feat(adk): allow disabling the built-in bash tool - #3222

Merged
EItanya merged 3 commits into
mainfrom
feat/disable-bash
Oct 15, 2026
Merged

EItanya merged 3 commits into
mainfrom
feat/disable-bash

Conversation

@supreme-gg-gg

@supreme-gg-gg supreme-gg-gg commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Depends on #3203 which makes OCI skills work again

Go ADK automatically registers bash when skills are loaded. Add runtime.skill_tools.disable_bash to disable it for the root agent and all subagents while preserving skill loading and file tools. Bash remains enabled by default.

Group file_search_tools, bash_venv_path, and disable_bash into a shared SkillToolsConfig used by controller defaults and ADK runtime configuration. Update Go and Python consumers, Helm values, documentation, and generated protobuf outputs. Existing flat settings must move into the nested block.

For controller-managed runtimes, set config.runtimeDefaults.skillTools.disableBash: true.

@supreme-gg-gg
supreme-gg-gg requested a review from a team as a code owner October 15, 2026 17:18
@github-actions github-actions Bot added the enhancement New feature or request label Oct 15, 2026
Comment thread proto/kagent/config/v1/config.proto Resolved
Comment thread helm/kagent/values.yaml Resolved
@github-actions github-actions Bot added enhancement New feature or request and removed enhancement New feature or request labels Oct 15, 2026
Signed-off-by: Jet Chiang <[email protected]>
Signed-off-by: Jet Chiang <[email protected]>
Signed-off-by: Jet Chiang <[email protected]>
@EItanya
EItanya added this pull request to the merge queue Oct 15, 2026
Merged via the queue into main with commit e9bab5b Oct 15, 2026
29 checks passed
@EItanya
EItanya deleted the feat/disable-bash branch October 15, 2026 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants