Repository navigation
feat: mount OCI skills through Substrate image volumes - #3203
Merged
Merged
Conversation
github-actions
Bot
added
enhancement
supreme-gg-gg
left a comment
supreme-gg-gg
left a comment
Contributor
There was a problem hiding this comment.
This change LGTM, two minor comments found by Codex, and also this would need rebasing
| if selected != 1 { | ||
| return "", fmt.Errorf("exactly one artifact source is required") | ||
| } | ||
| if source.Directory != "" { |
Contributor
There was a problem hiding this comment.
🤖 AI generated
Can we make validation and copying handle .git consistently? Mounted images can contain special files that the old extractor skipped. A FIFO under .git bypasses validation and blocks copySkill in os.ReadFile. Please validate everything we copy, or skip .git during copying too, and add regression coverage.
| require.NoError(t, os.WriteFile(filepath.Join(root, ".claude-plugin/plugin.json"), []byte(`{"name":"mounted-native"}`), 0o644)) | ||
| materialized, err := Materialize(t.Context(), agentplugin.Resources{Plugins: []agentplugin.Bundle{{Source: agentplugin.Source{Directory: root}}}}, Paths{Packages: t.TempDir(), Skills: t.TempDir()}) | ||
| require.NoError(t, err) | ||
| require.Equal(t, []string{root}, materialized.ClaudeFormatPluginRoots()) |
Contributor
There was a problem hiding this comment.
🤖 AI generated
Can we resolve root with filepath.EvalSymlinks before comparing? This assertion fails on macOS because the returned plugin root is canonicalized from /var/... to /private/var/....
EItanya
force-pushed
the
feat/oci-skill-volumes
branch
2 times, most recently
from
October 15, 2026 19:20
805f3db to
9a4a696
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
Author
Yea, we started using it recently when github runners were super sparse, and these have been so much faster! |
supreme-gg-gg
previously approved these changes
Oct 15, 2026
EItanya
force-pushed
the
feat/oci-skill-volumes
branch
from
October 15, 2026 20:59
e50a000 to
2af137c
Compare
supreme-gg-gg
previously approved these changes
Oct 15, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Oct 15, 2026
jhyoong
pushed a commit
to jhyoong/kagent
that referenced
this pull request
Oct 16, 2026
Depends on kagent-dev#3203 which makes OCI skills work again Go ADK automatically registers bash when skills are loaded. Add `runtime.skill_tools.disable_bash` to disable it for the root agent and all subagents while preserving skill loading and file tools. Bash remains enabled by default. Group `file_search_tools`, `bash_venv_path`, and `disable_bash` into a shared `SkillToolsConfig` used by controller defaults and ADK runtime configuration. Update Go and Python consumers, Helm values, documentation, and generated protobuf outputs. Existing flat settings must move into the nested block. For controller-managed runtimes, set `config.runtimeDefaults.skillTools.disableBash: true`. --------- Signed-off-by: Jet Chiang <[email protected]>
Signed-off-by: Eitan Yarmush <[email protected]>
Signed-off-by: Eitan Yarmush <[email protected]>
Signed-off-by: Eitan Yarmush <[email protected]>
Signed-off-by: Eitan Yarmush <[email protected]>
Signed-off-by: Eitan Yarmush <[email protected]>
Signed-off-by: Eitan Yarmush <[email protected]>
EItanya
force-pushed
the
feat/oci-skill-volumes
branch
from
October 16, 2026 13:29
2af137c to
8f025a8
Compare
EItanya
enabled auto-merge
October 16, 2026 13:31
EItanya
disabled auto-merge
October 16, 2026 13:44
This was referenced Oct 16, 2026
6 tasks done
3 tasks done
QuentinBisson
added a commit
to giantswarm/kagent-upstream
that referenced
this pull request
Oct 19, 2026
…gent-dev#3203 Signed-off-by: QuentinBisson <[email protected]>
QuentinBisson
added a commit
to giantswarm/kagent-upstream
that referenced
this pull request
Oct 19, 2026
* docs(fork): ledger facts as of 2026-10-19 Signed-off-by: QuentinBisson <[email protected]> * docs(fork): the compiled-skills carried row superseded by upstream kagent-dev#3203 Signed-off-by: QuentinBisson <[email protected]> * docs(fork): a machine-readable header on every carried-change file (#720) * docs(fork): a machine-readable header on every carried-change file Every file under fork/carried/ opens with the YAML front-matter proposed in #719, seeded from the row and the 2026-10-19 state board; scripts/fork/carried.sh skips the front-matter before checking the row; FORK.md names the fields. Signed-off-by: QuentinBisson <[email protected]> * docs(fork): drop internal tracker numbers from the headers, add the Substrate counterpart edges Signed-off-by: QuentinBisson <[email protected]> * ci(fork): check the ledger header schema The fork-ledger check runs scripts/fork/ledger-header.sh on fork/carried next to carried.sh --check, with its --self-test fixtures, the same rules as fork-ledger validate (#719). Signed-off-by: QuentinBisson <[email protected]> --------- Signed-off-by: QuentinBisson <[email protected]> --------- Signed-off-by: QuentinBisson <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OCI skills currently pull from inside the golden runtime, where registry access is unavailable. This moves those pulls to Substrate image volumes so the worker mounts the package before preparation and restores it with the actor, using the same registry credentials as workload images.
The compiler deduplicates digest-pinned images across skills, plugins, and shared agents. Runtimes load selected skills from the mounted directories, and the old OCI fetcher is removed. The public
source.ociAPI stays the same.Adds local-registry E2E coverage across Go ADK, Codex, Claude, and BYO ADK: skill discovery, loading
SKILL.mdthrough each harness's normal tools, real script execution, excluded skills, and suspend/resume. Model responses are deterministic; pulls, mounts, and tool execution are real. This checks runtime wiring, not real-model selection quality.