Repository navigation
Conversation
Signed-off-by: wenyizhou <[email protected]>
Author
|
@EItanya This is ready for review. GitHub is holding the full CI workflow for first-time-contributor approval; local ADK tests, vet, and repository Go lint are listed in the PR description. |
Contributor
Contributor
|
No worries. #2852 rebased |
Contributor
|
🤖 AI-generated review. Thanks for working on this, and sorry for the duplicate effort! #2852 has now merged and normalizes empty tool-call arguments through |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2851.
Problem
An empty
FunctionCall.Argsmap is omitted when ADK history is persisted and returns as nil after reload. OpenAI-shaped request converters marshalled that nil map as the string"null", which providers that require a JSON object reject on the next turn.Fix
Validation
go test ./adk/pkg/models -count=1go test ./adk/... -count=1go vet ./adk/pkg/modelsmake lint(0 issues)git diff --check