Repository navigation
fix: duplicate error message in responses and panic risk in OTEL env vars - #2029
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR refines error handling in the HTTP error middleware to distinguish between API-facing messages and underlying errors, and modernizes OTEL env var parsing by switching from strings.SplitN to strings.Cut.
Changes:
- Separate “underlying” error from API error message for logging and response composition.
- Avoid logging
pgx.ErrNoRowsas an error by checking the underlying error. - Simplify env var parsing using
strings.Cut.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| go/core/internal/httpserver/middleware_error.go | Adjusts logging and JSON response composition based on an extracted underlying error. |
| go/core/internal/controller/translator/agent/adk_api_translator.go | Replaces SplitN parsing with Cut for OTEL env var name/value extraction. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
github-actions
Bot
added
bug
moezdil
force-pushed
the
fix/error-response-otel-panic
branch
from
June 16, 2026 18:35
9cdcbb6 to
0fc6d77
Compare
…vars Signed-off-by: mesutoezdil <[email protected]>
moezdil
force-pushed
the
fix/error-response-otel-panic
branch
from
June 17, 2026 17:16
d79fa87 to
58d00ce
Compare
EItanya
reviewed
Jun 17, 2026
| )) | ||
|
|
||
| // Sort by environment variable name | ||
| var envVars []corev1.EnvVar |
Contributor
There was a problem hiding this comment.
Super mega nit: you know the capacity of this slice up front
EItanya
approved these changes
Jun 17, 2026
6 tasks done
social4hyq
pushed a commit
to social4hyq/homebrew-core
that referenced
this pull request
Sep 20, 2026
kagent 0.9.9 Created-by: HarmonybrewBot Commit-by: HarmonybrewBot Merged-by: HarmonybrewBot Description: Created by `brew bump` --- Created with `brew bump-formula-pr`.<details> <summary>release notes</summary> <pre><!-- Release notes generated using configuration in .github/release.yml at v0.9.9 --> ## What's Changed ### Bug Fixes * fix(ui): show agent edit control and prevent chat horizontal overflow by @amit-chaubey in kagent-dev/kagent#2002 * fix(controller): skip DB migration when DB schema is ahead of binary by @onematchfox in kagent-dev/kagent#1963 * fix(helm): rename $defaultProfider to $defaultProvider by @mesutoezdil in kagent-dev/kagent#2039 * fix: set Kind discriminator in ToLegacyTask A2A conversion by @Daniel-Vaz in kagent-dev/kagent#2038 * fix: duplicate error message in responses and panic risk in OTEL env vars by @mesutoezdil in kagent-dev/kagent#2029 * fix(substrate): bump amd64 runsc default to gVisor nightly 2026-06-02 by @Matcham89 in kagent-dev/kagent#2035 ### Other Changes * chore(deps): bump alpine from 3.23 to 3.24 in /docker/skills-init in the docker-minor-patch group across 1 directory by @dependabot[bot] in kagent-dev/kagent#2014 * chore(deps): bump the python-minor-patch group across 1 directory with 15 updates by @dependabot[bot] in kagent-dev/kagent#2017 ## New Contributors * @amit-chaubey made their first contribution in kagent-dev/kagent#2002 **Full Changelog**: https://github.com/kagent-dev/kagent/compare/v0.9.8...v0.9.9</pre> <p>View the full release notes at <a href="https://github.com/kagent-dev/kagent/releases/tag/v0.9.9">https://github.com/kagent-dev/kagent/releases/tag/v0.9.9</a>.</p> </details> <hr> See merge request: Harmonybrew/homebrew-core!11788
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2 bugs fixed in one commit.
RespondWithErrorwas producing"message: message"whenAPIError.Erris nil.Track the underlying error separately and omit the suffix when nil.
collectOtelEnvFromProcessaccessedparts[1]without a bounds check.Replaced with
strings.Cut, consistent with the rest of the codebase.