Skip to content

Commit dafd341

Browse files
committed
fix(skills): address private Git credential review
Signed-off-by: acherifi <[email protected]>
2 parents b462395 + 7a0a4fd commit dafd341

1,168 files changed

Lines changed: 70890 additions & 44474 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎.agents/skills/kagent‎

Lines changed: 0 additions & 1 deletion
This file was deleted.

‎.agents/skills/kagent-dev‎

Lines changed: 0 additions & 1 deletion
This file was deleted.
Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ The public API must not acquire Kubernetes scheduling, service-account, workload
2929

3030
```text
3131
go/api/v1alpha3/ CRD types and validation
32-
go/api/config/crd/bases/ generated CRDs
32+
helm/kagent-crds/templates/ generated CRDs and Helm packaging
3333
proto/ protobuf and Buf inputs
3434
go/api/gen/ generated Go protobuf code
3535
go/core/internal/grpcserver/ gRPC transport and policy
@@ -54,7 +54,7 @@ helm/ installation charts
5454
Useful commands:
5555

5656
```bash
57-
make controller-manifests # deepcopy, CRDs, and Helm CRD copies
57+
make controller-manifests # deepcopy and CRDs in the Helm chart
5858
make proto-lint proto-generate proto-breaking
5959
make -C go test
6060
make -C go lint
@@ -65,9 +65,10 @@ For SQL and store changes, follow [database guidance](../../../go/core/internal/
6565

6666
## CRD changes
6767

68+
- Follow [Kubernetes API conventions](../../../docs/kubernetes-api.md) for field presence, validation markers, and unions.
6869
- Modify only the intended v1alpha3 type and its validation.
6970
- Use explicit typed fields; avoid extension maps and speculative options.
70-
- Regenerate deepcopy code, CRDs, Helm CRDs, and RBAC when affected.
71+
- Regenerate deepcopy code, Helm-packaged CRDs, and RBAC when affected.
7172
- Verify generated schemas contain the intended fields and omit forbidden runtime infrastructure fields.
7273

7374
## Protobuf changes

.claude/skills/kagent-dev/references/scoped-authorization.md renamed to .agents/skills/kagent-dev/references/scoped-authorization.md

File renamed without changes.
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ CLI commands, exact MCP inputs, a worked example, recovery, and agent setup.
6666

6767
## Target API
6868

69-
- `Agent` is an `api.kagent.dev/v1alpha3` CRD pairing a template and Harness, each inline or referenced. It owns readiness and revision selection.
69+
- `Agent` is an `api.kagent.dev/v1alpha3` CRD pairing inline or referenced template behavior with a referenced Harness. It owns readiness and revision selection.
7070
- `Harness` is an `api.kagent.dev/v1alpha3` CRD describing a supported runtime adapter. The release-blocking adapters are kagent, Codex, and Claude.
7171
- `AgentTemplate` is an `api.kagent.dev/v1alpha3` CRD describing prompts, models, skills, plugins, MCP tools, and template-backed subagent tools (`tools[].subAgent`).
7272
- `Session` is a PostgreSQL-backed gRPC resource representing a conversation and its runtime lifecycle. Use the returned `context_id` for A2A interactions.

.claude/skills/kagent/references/sandboxes.md renamed to .agents/skills/kagent/references/sandboxes.md

Lines changed: 22 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -73,8 +73,9 @@ Clients that support MCP prompts can retrieve `sandbox-task` with required
7373
running tools. Server instructions describe the overall workflow; tool
7474
descriptions carry essential guidance for clients that only expose tools.
7575

76-
Fields in the required column must be supplied. File contents and output bytes
77-
use standard base64, including for text. Sandbox IDs are UUIDs returned by kagent.
76+
Fields in the required column must be supplied. `write_sandbox_file` input and
77+
`read_sandbox_outputs` output use standard base64, including for text. Sandbox
78+
IDs are UUIDs returned by kagent.
7879

7980
| Tool | Required inputs | Optional inputs / result |
8081
| --- | --- | --- |
@@ -86,7 +87,7 @@ use standard base64, including for text. Sandbox IDs are UUIDs returned by kagen
8687
| `get_sandbox_process`, `kill_sandbox_process` | `sandbox_id`, `process_id` | Get returns `status` and `exit_code`; Kill returns `exit_code` |
8788
| `read_sandbox_outputs` | `sandbox_id`, `process_id` | `stdout_offset`, `stderr_offset`; returns base64 streams, continuation offsets, `truncated` |
8889
| `write_sandbox_file` | `sandbox_id`, `path`, `data_base64` | `mode` (decimal Unix bits, e.g. `420` for `0644`); returns `bytes_written` |
89-
| `read_sandbox_file` | `sandbox_id`, `path` | Returns `data_base64` |
90+
| `read_sandbox_file` | `sandbox_id`, `path` | `offset`, `limit` (lines); returns numbered lines, an image, or a note describing the file |
9091

9192
Sandbox summaries contain `id`, `sandbox_template`, `state`, `operation`,
9293
`expires_at`, and optional `name` and `failure`. MCP returns the summary directly,
@@ -104,8 +105,8 @@ result; a completed tool call can carry a service error.
104105
sandbox when needed.
105106
2. **Stage inputs.** Write source, data, or an archive with `write_sandbox_file`.
106107
Decode/encode bytes using available tools, and verify `bytes_written`. MCP
107-
reads and writes accept at most 1 MiB of decoded file data per call. There is
108-
no file-offset or append input: repeated writes replace the destination.
108+
writes accept at most 1 MiB of decoded file data per call. There is no
109+
file-offset or append input: repeated writes replace the destination.
109110
3. **Execute.** Pass executable and arguments as `command`, with an explicit
110111
`cwd` when useful. Shell syntax needs an explicit shell, e.g.
111112
`["sh", "-c", "command > result.txt"]`. The executable must exist in the
@@ -121,8 +122,12 @@ result; a completed tool call can carry a service error.
121122
combined, without following future output. Pass both returned byte offsets
122123
into subsequent reads; continue when truncated and read again after process
123124
completion. Empty output or `truncated: false` does not mean the process ended.
124-
Read result files, decode them, and save deliverables into the user's working
125-
environment before cleanup. A path inside a sandbox is not a local artifact.
125+
Read result files with `read_sandbox_file`: text comes back as numbered
126+
lines, paged with `offset` and `limit`; PNG, JPEG and GIF images come back as
127+
images up to 10 MiB; other files come back as a description. Retrieve other
128+
files with a gRPC streaming client, and save deliverables into the user's
129+
working environment before cleanup. A path inside a sandbox is not a local
130+
artifact.
126131
6. **Finish.** Delete scratch sandboxes created for the task after retrieving
127132
results. Reused or deliberately retained sandboxes need an explicit handoff
128133
of their ID, expiration, and artifact paths. If cleanup fails, report it and
@@ -170,7 +175,7 @@ needed):
170175
{"sandbox_id":"SANDBOX_ID","process_id":"PROCESS_ID","stdout_offset":0,"stderr_offset":0}
171176
```
172177

173-
After successful completion, call `read_sandbox_file` and decode `data_base64`:
178+
After successful completion, call `read_sandbox_file`; the JSON arrives as line 1:
174179

175180
```json
176181
{"sandbox_id":"SANDBOX_ID","path":"summary.json"}
@@ -215,7 +220,7 @@ named `<fullname>-api` (`kagent-api` for the standard release) in the controller
215220
namespace, pointing to the controller's `/mcp` endpoint. AgentTemplate MCP
216221
references are same-namespace; another namespace needs its own registration.
217222
Bind the required sandbox tools in the AgentTemplate's `spec.tools` (or an
218-
Agent's inline `spec.template.tools`):
223+
Agent's inline `spec.template.inline.tools`):
219224

220225
```yaml
221226
tools:
@@ -239,10 +244,12 @@ tools:
239244
240245
Add `suspend_sandbox` and `resume_sandbox` when the agent needs that workflow.
241246
Sandbox ownership follows the identity authenticated by the MCP connection.
242-
For the Go kagent runtime, set `KAGENT_PROPAGATE_TOKEN=true` in the Harness's
243-
`spec.env` when its trusted MCP servers should receive the invoking caller's
244-
credentials. This opts configured servers into credential propagation; it is
245-
not a sandbox-specific permission. Do not assume this Go runtime setting applies
247+
For managed kagent runtimes, set `runtimeDefaults.tokenPropagation.enabled: true`
248+
in the controller config (Helm: `config.runtimeDefaults.tokenPropagation.enabled`)
249+
when their trusted MCP servers should receive the invoking caller's credentials.
250+
Standalone runtimes use `runtime.token_propagation.enabled: true` in their JSON
251+
config. This opts configured servers into credential propagation; it is
252+
not a sandbox-specific permission. Do not assume this kagent runtime setting applies
246253
to Codex or Claude. Session share tokens grant no sandbox access.
247254

248255
Creating or changing a SandboxTemplate is a separate setup operation. It requires
@@ -251,13 +258,13 @@ supplies the guest entrypoint. It does not inherit a Harness. Use
251258
`docs/architecture/sandboxes.md` and `go/api/v1alpha3/sandboxtemplate_types.go`
252259
for its schema and preparation requirements.
253260

254-
For a gRPC client, use `kagent.api.v1alpha1.SandboxService` for lifecycle and
261+
For a gRPC client, use `kagent.api.v1.SandboxService` for lifecycle and
255262
upstream `ateenv.v1alpha.ProcessService` / `FileSystemService` on the same
256263
apiserver connection for guest work. Send exactly one `kagent-sandbox-id`
257264
metadata value with the Sandbox UUID plus the connection's normal authentication.
258265
Route through kagent; Actor IDs and private guest endpoints are not client APIs.
259266

260267
Source contracts: `go/core/internal/mcp/sandboxes.go`,
261-
`proto/kagent/api/v1alpha1/sandboxes.proto`, and
268+
`proto/kagent/api/v1/sandboxes.proto`, and
262269
`proto/ateenv/v1alpha/guest.proto`. Runtime limits and process semantics are in
263270
`go/sandbox/guest/README.md`.

‎.claude/skills/kagent‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
../../.agents/skills/kagent

‎.claude/skills/kagent-dev‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
../../.agents/skills/kagent-dev

‎.github/ISSUE_TEMPLATE/3-documentation.yml‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
name: 📚 Documentation Request
22
description: Report a documentation bug, missing info, or suggest an improvement
33
title: "[DOCS] "
4-
labels: []
5-
type: Documentation
4+
labels:
5+
- documentation
6+
type: Task
67
assignees: []
78

89
body:
Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,14 @@
11
name: Build release artifacts
2-
description: Build CLI binaries, checksums and versioned Helm chart archives
2+
description: Build CLI binaries and checksums independently of image publishing
33
inputs:
44
version:
55
description: Version without a v prefix
66
required: true
77
runs:
88
using: composite
99
steps:
10-
- name: Build CLI and charts
10+
- name: Build CLI
1111
shell: bash
1212
env:
1313
VERSION: ${{ inputs.version }}
14-
run: |
15-
make build-cli
16-
make helm-version
14+
run: make build-cli

0 commit comments

Comments
 (0)