Skip to content

Commit 3fc96de

Browse files
adalundheclaude
andcommitted
test(ui): stop mocking recovery on a RevertSession response
Only GetSession returns `recovery`, so a revert response carries none. The revert test still mocked one and asserted that the client mapped it, which pinned a response the server cannot send. The revert test now expects no `recovery`. Its failed-message mapping assertion moves to a GetSession test, which is the response that carries those references. Verified on Node 24: `tsc --noEmit`, eslint, and `vitest run src/components/chat src/pages src/api` pass. Signed-off-by: Ada Lundhe <[email protected]> Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent 40e3702 commit 3fc96de

1 file changed

Lines changed: 17 additions & 8 deletions

File tree

‎ui/src/api/operations.test.ts‎

Lines changed: 17 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -994,25 +994,34 @@ describe("agent instances", () => {
994994
expect(isNotFound(missing)).toBe(true);
995995
});
996996

997-
it("reverts through the existing Session RPC and retains exact failed message references", async () => {
997+
it("reverts through the existing Session RPC", async () => {
998998
let received: string | undefined;
999999
serve(({ service }) => {
10001000
service(SessionService, {
10011001
revertSession: (request) => {
10021002
received = request.sessionId;
1003-
return { session: instanceMessage({
1004-
state: RuntimeState.SUSPENDED,
1005-
recovery: { automatic: false, needed: false, failedMessages: [
1006-
{ taskId: "completed-task", messageId: "discarded-message" },
1007-
] },
1008-
}) };
1003+
// Only GetSession returns recovery, so the revert response carries none.
1004+
return { session: instanceMessage({ state: RuntimeState.SUSPENDED }) };
10091005
},
10101006
});
10111007
});
10121008
const reverted = await apiClient.agentInstances.revert(INSTANCE_ID);
10131009
expect(received).toBe(INSTANCE_ID);
10141010
expect(reverted.state).toBe("suspended");
1015-
expect(reverted.recovery).toEqual({ automatic: false, needed: false, failedMessages: [
1011+
expect(reverted.recovery).toBeUndefined();
1012+
});
1013+
1014+
it("retains exact failed message references from GetSession", async () => {
1015+
serve(({ service }) => {
1016+
service(SessionService, {
1017+
getSession: () => ({ session: instanceMessage({
1018+
recovery: { automatic: false, needed: false, failedMessages: [
1019+
{ taskId: "completed-task", messageId: "discarded-message" },
1020+
] },
1021+
}) }),
1022+
});
1023+
});
1024+
expect((await apiClient.agentInstances.get(INSTANCE_ID)).recovery).toEqual({ automatic: false, needed: false, failedMessages: [
10161025
{ taskId: "completed-task", messageId: "discarded-message" },
10171026
] });
10181027
});

0 commit comments

Comments
 (0)