Repository navigation
Commit 0b0bfe8
committed
fix: keep grepping when an entry cannot be statted
_classify_walk_entry called Path.is_file() unguarded. That swallows ENOENT,
ENOTDIR, EBADF and ELOOP, but raises on EACCES -- so a stat failure escaped
the classifier and propagated out of grep_content, discarding every match
already found elsewhere in the tree.
The reachable case is a directory that is readable but not searchable (mode
0o444): os.walk lists its children fine, then stat on each child is denied.
The suite's existing permission tests use mode 0o000, where os.walk itself
fails and the error is already handled by the walk_errors path, so they
could not catch this.
Classify any OSError from those stats as UNREADABLE instead, matching the Go
runtime, whose classifyWalkEntry already maps every EvalSymlinks/Stat failure
to walkEntryUnreadable. The caller counts UNREADABLE and keeps walking.
Also corrects the docstring, which claimed this divergence was "not reachable
through any case we could construct". EACCES reaches it trivially. The
remaining divergence is narrower and is now described accurately.
Reported by EItanya in review of #2267.
Signed-off-by: brandonkeung <[email protected]>1 parent b4f76af commit 0b0bfe8
2 files changed
Lines changed: 91 additions & 18 deletions
File tree
- python/packages/kagent-skills/src/kagent
- skills
- tests/unittests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
56 | 56 | | |
57 | 57 | | |
58 | 58 | | |
59 | | - | |
60 | | - | |
61 | | - | |
62 | | - | |
63 | | - | |
64 | | - | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
65 | 67 | | |
66 | 68 | | |
67 | 69 | | |
68 | 70 | | |
69 | | - | |
70 | | - | |
71 | | - | |
72 | | - | |
73 | | - | |
74 | | - | |
75 | | - | |
76 | | - | |
77 | | - | |
78 | | - | |
79 | | - | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
80 | 96 | | |
81 | | - | |
82 | 97 | | |
83 | 98 | | |
84 | 99 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
503 | 503 | | |
504 | 504 | | |
505 | 505 | | |
| 506 | + | |
| 507 | + | |
| 508 | + | |
| 509 | + | |
| 510 | + | |
| 511 | + | |
| 512 | + | |
| 513 | + | |
| 514 | + | |
| 515 | + | |
| 516 | + | |
| 517 | + | |
| 518 | + | |
| 519 | + | |
| 520 | + | |
| 521 | + | |
| 522 | + | |
| 523 | + | |
| 524 | + | |
| 525 | + | |
| 526 | + | |
| 527 | + | |
| 528 | + | |
| 529 | + | |
| 530 | + | |
| 531 | + | |
| 532 | + | |
| 533 | + | |
506 | 534 | | |
507 | 535 | | |
508 | 536 | | |
| |||
618 | 646 | | |
619 | 647 | | |
620 | 648 | | |
| 649 | + | |
| 650 | + | |
| 651 | + | |
| 652 | + | |
| 653 | + | |
| 654 | + | |
| 655 | + | |
| 656 | + | |
| 657 | + | |
| 658 | + | |
| 659 | + | |
| 660 | + | |
| 661 | + | |
| 662 | + | |
| 663 | + | |
| 664 | + | |
| 665 | + | |
| 666 | + | |
| 667 | + | |
| 668 | + | |
| 669 | + | |
| 670 | + | |
| 671 | + | |
| 672 | + | |
| 673 | + | |
| 674 | + | |
| 675 | + | |
| 676 | + | |
| 677 | + | |
| 678 | + | |
621 | 679 | | |
622 | 680 | | |
623 | 681 | | |
| |||
0 commit comments