Restore ability to accept relative paths#75
Closed
gfyoung wants to merge 1 commit intokaelzhang:masterfrom
Closed
Conversation
Blocking the acceptance of relative paths by throwing errors is a relatively harsh change that has made it difficult for downstream libraries (e.g., eslint) to upgrade. Given that relative paths have undefined treatment in ".gitignore" and the usage of this library beyond ".gitignore" behavior, it seems fair to give downstream users the chance to customize the handling of these cases for their own cases. xref: kaelzhang#20
Contributor
Author
|
@kaelzhang: Given what you said a couple of years ago (#20 (comment)), I'm curious what your thoughts are on this now. If you're good with relaxing this requirement via constructor configuration, I'll proceed with test cases. |
Contributor
Author
|
@kaelzhang: Friendly ping here. Would be helpful to get your thoughts on this before I make this a full PR. |
Owner
|
close coz of inactivity |
kaelzhang
added a commit
that referenced
this pull request
Dec 19, 2021
kaelzhang
added a commit
that referenced
this pull request
Dec 19, 2021
Contributor
Author
|
@kaelzhang : Thanks for pushing these commits. I missed the notification that you marked this PR as ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocking the acceptance of relative paths by throwing errors is a relatively harsh change that has made it difficult for
downstream libraries (e.g.,
eslint) to upgrade.Given that relative paths have undefined treatment in ".gitignore" and the usage of this library beyond ".gitignore" behavior, it seems fair to give downstream users the chance to customize the handling of these cases for their own cases.
xref: #20