Fix types for node16#146
Merged
kaelzhang merged 3 commits intokaelzhang:masterfrom Jan 13, 2025
Merged
Conversation
kaelzhang
added a commit
that referenced
this pull request
Jan 13, 2025
kaelzhang
added a commit
that referenced
this pull request
Jan 13, 2025
Owner
|
Really thanks for your work buddy. Landed in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #96
This fixes issues with type declarations for imports in various environments. Checks all the boxes at https://arethetypeswrong.github.io/?p=ignore
Changes
@typescript/eslintto facilitate testingexport = import-- I believe this is the "correct" way to declare the exports for a CommonJS module. Other approaches work in many cases, but this is the only way that works for everything.module.exports.isPathValid = isPathValid-- Apparently there's a difference between this andfactory.isPathValid = isPathValidand in some situations, named exports only work when set directly onexports.Compatibility Considerations
In some situations, this requires that people enable
esModuleInteropin their tsconfig.json in order to useimport ignore from "ignore". Otherwise they need to useimport * as ignore from "ignore". I think it's extremely unlikely that people will find themselves in this situation, but it does technically make this a breaking change.