#74 (chore): avoid assignment chaining

kaelzhang · kaelzhang · commit 7879eef821f7 · 2021-11-03T16:01:41.000+08:00
diff --git a/index.js b/index.js
@@ -292,10 +292,11 @@ const makeRegex = (pattern, ignorecase) => {
   let source = regexCache[pattern]
 
   if (!source) {
-    regexCache[pattern] = source = REPLACERS.reduce(
+    source = REPLACERS.reduce(
       (prev, current) => prev.replace(current[0], current[1].bind(pattern)),
       pattern
     )
+    regexCache[pattern] = source
   }
 
   return ignorecase

Original file line number	Diff line number	Diff line change
`@@ -292,10 +292,11 @@ const makeRegex = (pattern, ignorecase) => {`
`292`	`292`	`let source = regexCache[pattern]`
`293`	`293`
`294`	`294`	`if (!source) {`
`295`		`- regexCache[pattern] = source = REPLACERS.reduce(`
	`295`	`+ source = REPLACERS.reduce(`
`296`	`296`	`(prev, current) => prev.replace(current[0], current[1].bind(pattern)),`
`297`	`297`	`pattern`
`298`	`298`	`)`
	`299`	`+ regexCache[pattern] = source`
`299`	`300`	`}`
`300`	`301`
`301`	`302`	`return ignorecase`