Skip to content

Comments

feat: support strikethrough GFM syntax ('~~')#428

Merged
Songmu merged 5 commits intomainfrom
strike
Sep 3, 2025
Merged

feat: support strikethrough GFM syntax ('~~')#428
Songmu merged 5 commits intomainfrom
strike

Conversation

@Songmu
Copy link
Collaborator

@Songmu Songmu commented Sep 3, 2025

The following are extensions to CommonMark in GitHub Flavored Markdown:

  • Tables
  • Strikethrough
  • Task list items
  • Autlinks (without angle brackets)
  • (Disallowed Raw HTML)

Among these, deck already supports tables. We will additionally support strikethrough.

I don't think we need to support the others in the future.

This does not currently appear. It only appears when the typographer extension is enabled, but deck does not enable that extension.
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

…LElements`

And add a comment explaining the reason for its inclusion.
@github-actions

This comment has been minimized.

@Songmu Songmu marked this pull request as ready for review September 3, 2025 11:11
@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2025

Code Metrics Report

main (b77172e) #428 (c533f15) +/-
Coverage 31.7% 31.9% +0.1%
Code to Test Ratio 1:0.8 1:0.8 -0.1
Test Execution Time 9s 10s +1s
Details
  |                     | main (b77172e) | #428 (c533f15) |  +/-  |
  |---------------------|----------------|----------------|-------|
+ | Coverage            |          31.7% |          31.9% | +0.1% |
  |   Files             |             29 |             29 |     0 |
  |   Lines             |           3186 |           3185 |    -1 |
+ |   Covered           |           1013 |           1017 |    +4 |
- | Code to Test Ratio  |          1:0.8 |          1:0.8 |  -0.1 |
  |   Code              |           6529 |           6540 |   +11 |
  |   Test              |           5695 |           5695 |     0 |
- | Test Execution Time |             9s |            10s |   +1s |

Code coverage of files in pull request scope (68.4% → 69.3%)

Files Coverage +/- Status
md/md.go 79.7% +1.0% modified
style.go 0.0% 0.0% modified

Reported by octocov

@Songmu Songmu added enhancement New feature or request minor labels Sep 3, 2025
@Songmu Songmu merged commit 9380dca into main Sep 3, 2025
3 checks passed
@Songmu Songmu deleted the strike branch September 3, 2025 11:45
@github-actions github-actions bot mentioned this pull request Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant