Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refines logging functionality and output messages across several modules while introducing a new ASCII art display when standard output is enabled.
- Comment out outdated log calls in protocol transaction handling.
- Modify log format in block reporting.
- Add conditional ASCII art printing in the executor module.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/protocols/protocol_transaction_in.cpp | Commented out log messages to disable obsolete debug/info outputs. |
| src/protocols/protocol_block_in.cpp | Adjusted the log formatting string by removing the "Block" prefix. |
| src/executor/executor.cpp & executor.hpp | Added an ASCII art display and a new flag to optionally control its output. |
Comments suppressed due to low confidence (1)
src/executor/executor.cpp:371
- [nitpick] Ensure that printing ASCII art to standard output is appropriate for production environments; consider gating this feature by an environment flag if necessary.
void executor::print_ascii_art() {
fpelliccioni
force-pushed
the
feat/better-logs
branch
from
7a85b07 to
eb4b6ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.