Repository navigation
Commit 150d2fc
Fix ODFV output projection in offline retrieval (feast-dev#6099)
Changes:
- Modified RetrievalJob.to_arrow() to filter ODFV outputs based on requested
features from metadata, matching online retrieval behavior
- Added test_odfv_projection to verify the fix and prevent regression
Before this fix:
- Online: features=['odfv:feature_a'] -> returns feature_a only ✓
- Offline: features=['odfv:feature_a'] -> returns feature_a, feature_b, feature_c ✗
After this fix:
- Both online and offline return only the requested features ✓
This ensures schema consistency between training (offline) and serving (online)
pipelines, preventing downstream issues in ML workflows.
Fixes feast-dev#6099
Signed-off-by: Jitendra Yejare <[email protected]>1 parent 607b640 commit 150d2fc
3 files changed
Lines changed: 32 additions & 38 deletions
File tree
- sdk/python
- feast
- infra/offline_stores
- tests/integration/offline_store
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1447 | 1447 | | |
1448 | 1448 | | |
1449 | 1449 | | |
| 1450 | + | |
| 1451 | + | |
| 1452 | + | |
| 1453 | + | |
| 1454 | + | |
| 1455 | + | |
| 1456 | + | |
| 1457 | + | |
| 1458 | + | |
| 1459 | + | |
| 1460 | + | |
| 1461 | + | |
| 1462 | + | |
1450 | 1463 | | |
1451 | 1464 | | |
1452 | 1465 | | |
| |||
1473 | 1486 | | |
1474 | 1487 | | |
1475 | 1488 | | |
1476 | | - | |
| 1489 | + | |
1477 | 1490 | | |
1478 | 1491 | | |
1479 | 1492 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
157 | 157 | | |
158 | 158 | | |
159 | 159 | | |
160 | | - | |
| 160 | + | |
161 | 161 | | |
162 | 162 | | |
163 | 163 | | |
164 | 164 | | |
165 | 165 | | |
166 | 166 | | |
167 | 167 | | |
168 | | - | |
169 | | - | |
170 | | - | |
171 | | - | |
172 | | - | |
173 | | - | |
174 | | - | |
175 | | - | |
176 | | - | |
177 | | - | |
178 | | - | |
179 | | - | |
180 | | - | |
181 | | - | |
182 | | - | |
183 | | - | |
184 | | - | |
185 | | - | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
186 | 185 | | |
187 | 186 | | |
188 | 187 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
939 | 939 | | |
940 | 940 | | |
941 | 941 | | |
942 | | - | |
943 | | - | |
944 | | - | |
945 | | - | |
946 | | - | |
947 | | - | |
948 | | - | |
949 | | - | |
950 | | - | |
951 | | - | |
952 | | - | |
953 | | - | |
954 | | - | |
955 | | - | |
956 | | - | |
957 | | - | |
958 | | - | |
959 | | - | |
0 commit comments