Use SPDX identifier in POMs#979
Use SPDX identifier in POMs#979lhazlewood merged 3 commits intojwtk:masterfrom TheMrMilchmann:tmm/spdx
Conversation
This replaces the custom name with an SPDX identifier to enable tooling to automatically detect the correct license. See https://spdx.org/licenses/Apache-2.0.html
|
Just checked the Ci failure. It's unrelated to this change and instead seems to be a spurious issue while downloading the JDK. |
|
@TheMrMilchmann I'll re-run the job, looks like that might have been a GH Actions infra issue? |
|
Just tried to run it myself as well - the setup JDK task is failing. Seems to be due to: Line 23 in 2ad964a That project is here: https://github.com/oracle-actions/setup-java But we're referencing I wonder: @TheMrMilchmann can you update the What I don't understand is that it was working until recently, so maybe Oracle stopped hosting the file? Not sure. |
|
There does indeed seem to be a version mismatch. From the failed build: Definitely trying something with JDK 21 instead of 17. I looked in the old version 1.1.0 jdk.java.net-uri.properties file and downloaded the referenced file for JDK 17 to my local system just now: and then verified the file: So it seems that the file is still there, and I'm assuming that changing the uses: oracle-actions/[email protected] |
|
This appears to be intentional oracle-actions/setup-java#94 (comment). I'm currently travelling but can pin the version on Thursday. |
See #979 for reference.
|
I'm confused as to why it failed, but there is this: Which isn't the exact tarball referenced in the I wonder if we'll have to use the explicit - name: Set up JDK
uses: oracle-actions/[email protected]
with:
uri: 'https://download.java.net/java/GA/jdk17.0.2/dfd4a8d0985749f896bed50d7138ee7f/8/GPL/openjdk-17.0.2_linux-aarch64_bin.tar.gz'I'm assuming that will work - it's worth a shot. If not, I think it's probably time to revert from using |
|
@TheMrMilchmann so I don't keep asking you to try things for me, I created this: #980 Hopefully when that is done, your PR will 'just work'. I'll give it a shot today. |
|
@TheMrMilchmann all works as expected now, so I squashed/merged. Sorry for the confusion/delay, and thanks for the pull request! |
No worries & thanks for taking care! 😊 |
This replaces the custom name with an SPDX identifier to enable tooling to automatically detect the correct license. Using an SPDX identifier is recommended by the official Maven documentation.
See https://spdx.org/licenses/Apache-2.0.html