Merged
Conversation
Collaborator
|
This looks good to me. I will test it before tomorrow in case everybody else is busy. Thanks @dbfannin ! 🙂 |
Owner
|
@dbfannin — Looks great, thanks! There should be no need for the Can you please update it to Thanks again! |
added 5 commits
May 9, 2017 07:34
…addReadme # Conflicts: # generators/app/templates/gulpfile.js
# Conflicts: # README.md # generators/app/templates/gulpfile.js
Contributor
Author
|
Resolved conlicts and updated the path.join. @jvandemo, this should be good to go now. Thanks! |
Owner
Contributor
Author
|
Well that's embarrassing. Not sure how I managed to do that. It should be good to go now (fingers crossed) |
Collaborator
|
It looks good to me now 👍 |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR copies the README.MD file at the root of the generated project to the /dist directory.
The thought is that the user shouldn't have to maintain multiple README files. However, if you see value in there being a separate README for distributable files, let me know and I can modify.