feat(SASS): Allow import scss files from lib or dependencies#100
Merged
jvandemo merged 1 commit intojvandemo:masterfrom May 27, 2017
Merged
feat(SASS): Allow import scss files from lib or dependencies#100jvandemo merged 1 commit intojvandemo:masterfrom
jvandemo merged 1 commit intojvandemo:masterfrom
Conversation
paesku
reviewed
May 25, 2017
paesku
left a comment
paesku
left a comment
There was a problem hiding this comment.
I tested this locally and it works like a charme.
IMO this request should be accepted, since it's such an important part when building libraries and sharing settings, functions and mixins via scss files.
Owner
|
@rtrompier — Thank you, this works great! 👍 Would you be able to add a section to the README so I can merge this? Thanks in advance! |
Owner
|
@rtrompier — I have added the documentation and released your changes as v10.2.0. Thank you for your contribution! 👍 |
|
Question: @rtrompier - where inside the generator code would I put a global .scss file in which to import my styles - I have several components and want to have it used for them all |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature allow the developer to import other SCSS files into the scss component file.
Eg :
From node_modules dependencies : @import '~angular/material/theming';
From other component : @import '../other-component/other-component.component.scss';