chore: update messaging around compatibility and recommended actions before updating #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…WPGraphQL plugin update available. This provides a bit more clarity and more straightforward actions to take.
- make messaging in UpdateChecker.php consistent with PluginsScreenLoader
…t_compatibility_warning_message()` function so we can manage the language for the messaging in one place.
8 tasks
jasonbahl
changed the title
Collaborator
Author
|
@justlevine getting this merged. Feel free to follow up if you have reason to believe this should be changed. |
justlevine
pushed a commit
that referenced
this pull request
Apr 18, 2025
This fixes the following error appearing on the GraphQL endpoint: `Deprecated: preg_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated`
justlevine
pushed a commit
that referenced
this pull request
Apr 18, 2025
chore: update package lock
justlevine
pushed a commit
that referenced
this pull request
Apr 18, 2025
chore: update workflow to use master instead of main
justlevine
pushed a commit
that referenced
this pull request
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Updates the messaging re: plugin compatibility and recommended actions users should take prior to updating.
Also abstracts the messaging into a single
get_compatibility_warning_message()method for better reusability and reduced duplicate efforts when/if we need to make adjustments to the messaging.Any other comments?
Update Screen
BEFORE:
AFTER:
Plugin Screen
BEFORE:
AFTER: